Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZOOKEEPER-3835: Deprecate IOUtils copyBytes #1357

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

ZOOKEEPER-3835: Deprecate IOUtils copyBytes #1357

wants to merge 2 commits into from

Conversation

belugabehr
Copy link
Contributor

No description provided.

@belugabehr belugabehr mentioned this pull request May 19, 2020
Closed
@belugabehr
Copy link
Contributor Author

[WARNING] /home/travis/build/apache/zookeeper/zookeeper-server/src/test/java/org/apache/zookeeper/test/ClientBase.java:[703,20] copyBytes(java.io.InputStream,java.io.OutputStream,int,boolean) in org.apache.zookeeper.common.IOUtils has been deprecated
[INFO] 1 warning
[INFO] -------------------------------------------------------------
[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] /home/travis/build/apache/zookeeper/zookeeper-server/src/test/java/org/apache/zookeeper/test/StringUtilTest.java: warnings found and -Werror specified

That's unfortunate that I can't deprecate things.

nkalmar
nkalmar requested changes May 20, 2020
View reviewed changes
Copy link
Contributor

@nkalmar nkalmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it is still used in ClientBase, and deprecated, if not supressed, is set to trigger build failure.

ctubbsii
ctubbsii suggested changes May 21, 2020
View reviewed changes
zookeeper-server/src/main/java/org/apache/zookeeper/common/IOUtils.java
@@ -68,6 +68,7 @@ public static void cleanup(Logger log, Closeable... closeables) {

/**
* Copies from one stream to another.
* Deprecated. No longer used in ZK.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's deprecated, it should use the @Deprecated annotation, and have a useful @deprecated javadoc message for any current callers.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To get past the build problems, just suppress the warning wherever it must still be used internally... or replace internal calls with whatever is replacing this.

asfgit pushed a commit that referenced this pull request Nov 9, 2020
@belugabehr @nkalmar
ZOOKEEPER-3836: Use Commons and JDK Functions in ClientBase
7f66c76 
Related to #1357

Author: David Mollitor <[email protected]>

Reviewers: Enrico Olivelli <[email protected]>, Norbert Kalmar <[email protected]>

Closes #1358 from belugabehr/ZOOKEEPER-3836
RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Aug 31, 2022
@belugabehr @RokLenarcic
ZOOKEEPER-3836: Use Commons and JDK Functions in ClientBase
eac5f2a 
Related to apache#1357

Author: David Mollitor <[email protected]>

Reviewers: Enrico Olivelli <[email protected]>, Norbert Kalmar <[email protected]>

Closes apache#1358 from belugabehr/ZOOKEEPER-3836
RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Aug 31, 2022
@belugabehr @RokLenarcic
ZOOKEEPER-3836: Use Commons and JDK Functions in ClientBase
f88de82 
Related to apache#1357

Author: David Mollitor <[email protected]>

Reviewers: Enrico Olivelli <[email protected]>, Norbert Kalmar <[email protected]>

Closes apache#1358 from belugabehr/ZOOKEEPER-3836
RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Aug 31, 2022
@belugabehr @RokLenarcic
ZOOKEEPER-3836: Use Commons and JDK Functions in ClientBase
b2ede11 
Related to apache#1357

Author: David Mollitor <[email protected]>

Reviewers: Enrico Olivelli <[email protected]>, Norbert Kalmar <[email protected]>

Closes apache#1358 from belugabehr/ZOOKEEPER-3836
RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Sep 3, 2022
@belugabehr @RokLenarcic
ZOOKEEPER-3836: Use Commons and JDK Functions in ClientBase
cf16d0e 
Related to apache#1357

Author: David Mollitor <[email protected]>

Reviewers: Enrico Olivelli <[email protected]>, Norbert Kalmar <[email protected]>

Closes apache#1358 from belugabehr/ZOOKEEPER-3836
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctubbsii ctubbsii ctubbsii requested changes

@nkalmar nkalmar nkalmar requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@belugabehr @ctubbsii @nkalmar