Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZOOKEEPER-3835: Deprecate IOUtils copyBytes #1357

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

ZOOKEEPER-3835: Deprecate IOUtils copyBytes #1357

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
017094e
ZOOKEEPER-3835: Deprecate IOUtils copyBytes
belugabehr May 19, 2020
485539c
Remove official JDK deprecated tag
belugabehr May 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove official JDK deprecated tag
  • Loading branch information
@belugabehr
belugabehr committed May 19, 2020
commit 485539c3c0ae1dcd2f3598f84031003f26606eba
3 changes: 1 addition & 2 deletions zookeeper-server/src/main/java/org/apache/zookeeper/common/IOUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ public static void cleanup(Logger log, Closeable... closeables) {

/**
* Copies from one stream to another.
* Deprecated. No longer used in ZK.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's deprecated, it should use the @Deprecated annotation, and have a useful @deprecated javadoc message for any current callers.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To get past the build problems, just suppress the warning wherever it must still be used internally... or replace internal calls with whatever is replacing this.

*
* @param in
* InputStrem to read from
Expand All @@ -78,9 +79,7 @@ public static void cleanup(Logger log, Closeable... closeables) {
* @param close
* whether or not close the InputStream and OutputStream at the
* end. The streams are closed in the finally clause.
* @deprecated No longer used in ZK
*/
@Deprecated
public static void copyBytes(InputStream in, OutputStream out, int buffSize, boolean close) throws IOException {
try {
copyBytes(in, out, buffSize);
Expand Down