ZOOKEEPER-3938: java client: upgrade jline from 2.x to 3.x and adapt Completer to the new API. #1458
+51
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make prompt as follows. [zk: ip:port(CONNECTED) 0] ls /zookeeper/quota
fetch new features.
merge from origin to resolve CI failures.
maoling
reviewed
Sep 19, 2020
zookeeper-server/src/main/java/org/apache/zookeeper/JLineZNodeCompleter.java
Show resolved
Hide resolved
|
@eolivelli Can you help me review my PR? And CI maven build failed, does it matter? I build the code without my commit and get the same test error. |
|
@symat it seems jenkins failed on make c client module which is irrelevant to this commit. Could you take a look? |
|
should be fix after #1462 |
|
What's the difference with #1461 ? |
eolivelli
requested changes
Sep 20, 2020
ignore UserInterruptException in zkCli
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several Jline 3.x versions. I think it's time to adapt new version jlines. I made some adjustments to the 'JLineZNodeCompleter.java' in this pr.
the result is as follows.
