Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/gradle.kts koin #122

Merged
merged 10 commits into from
Sep 27, 2022
Merged

Conversation

MatthewDauterman
Copy link
Contributor

Changelog

Your description here.

Moved koin branch to .gradle.kts, also updated the unit tests on this branch as they were still failing.

Added

Changed

  • Gradle to gradle.kts

Removed

  • old gradle

Is there test coverage for your changes?

No, but ktlintCheck, and test pass

Screenshots

@MatthewDauterman MatthewDauterman marked this pull request as ready for review September 22, 2022 19:29
Copy link
Contributor

@bradyjohnk bradyjohnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MatthewDauterman MatthewDauterman merged commit 4be5607 into starter-koin Sep 27, 2022
@MatthewDauterman MatthewDauterman deleted the feature/gradle.kts-koin branch September 27, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants