Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/gradle.kts koin #122

Merged
merged 10 commits into from
Sep 27, 2022
Merged

Feature/gradle.kts koin #122

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b06f30e
converting koin branch over to kts stable build checkpoint
MatthewDauterman Sep 8, 2022
42131d4
some cleanup
MatthewDauterman Sep 8, 2022
a26c5ae
stable checkpoint
MatthewDauterman Sep 15, 2022
8927268
stable checkpoint
MatthewDauterman Sep 15, 2022
1502279
commiting to restart
MatthewDauterman Sep 15, 2022
3a95bbf
code cleanup
MatthewDauterman Sep 15, 2022
177c67f
removed MaxPermSize(deprecated) so Daemon will build
MatthewDauterman Sep 15, 2022
3c4d330
some fixes for failing unit tests, more on the way hopefully
MatthewDauterman Sep 22, 2022
27b8ab2
fixes for 'Koin application already been started'
MatthewDauterman Sep 22, 2022
b53ff00
ktlint fix
MatthewDauterman Sep 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
code cleanup
  • Loading branch information
@MatthewDauterman
MatthewDauterman committed Sep 15, 2022
commit 3a95bbfcbbb5eac34bc9272d81322463c0204eb1
35 changes: 1 addition & 34 deletions app/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ plugins {
id("kotlin-parcelize")
id("com.google.firebase.crashlytics")
id("pmd")
id("checkstyle")
id("jacoco")
id("com.google.gms.google-services")
}
Expand Down Expand Up @@ -138,35 +137,6 @@ android {
}
}

// App dependency versions
val appCompatVersion = "1.4.1"
val supportVersion = "1.0.0"
val playServicesVersion = "18.0.1"
val lifecycleVersion = "2.0.0"
val lifecycleRuntimeVersion = "2.4.1"
val koinVersion = "3.2.0"
val retrofitVersion = "2.9.0"
val okHttpVersion = "4.9.1"
val moshiVersion = "1.13.0"
val coreVersion = "1.7.0"
val constraintLayoutVersion = "2.1.3"
val recyclerViewVersion = "1.2.1"
val materialVersion = "1.6.0"
val rxJavaVersion = "2.2.21"
val rxAndroidVersion = "2.1.1"
val timberVersion = "5.0.1"
val leakCanaryVersion = "2.7"

// Test dependency versions
val mockitoVersion = "4.4.0"
val mockitoKotlinVersion = "1.6.0"
val robolectricVersion = "4.7.3"
val androidTestSupportVersion = "1.4.0"
val espressoVersion = "3.4.0"
val junitVersion = "4.13.2"
val junitTestVersion = "1.1.3"


dependencies {
implementation(platform("com.google.firebase:firebase-bom:${Dependencies.firebaseBomVersion}"))
implementation("com.google.firebase:firebase-analytics-ktx")
Expand Down Expand Up @@ -264,7 +234,6 @@ dependencies {
testImplementation("com.nhaarman:mockito-kotlin-kt1.1:${Dependencies.mockitoKotlinVersion}")
testImplementation("com.squareup.okhttp3:mockwebserver:${Dependencies.okHttpVersion}")


// Android JUnit Runner, JUnit Rules, and Espresso
// Android JUnit Runner, JUnit Rules, and Espresso
androidTestImplementation("androidx.test:runner:${Dependencies.androidTestSupportVersion}")
Expand All @@ -278,9 +247,7 @@ dependencies {
androidTestImplementation("com.nhaarman:mockito-kotlin-kt1.1:${Dependencies.mockitoKotlinVersion}")
}

tasks.register<Pmd>("pmd") {

}
tasks.register<Pmd>("pmd") {}

tasks.named<Pmd>("pmd").configure {
dependsOn("assembleDebug")
Expand Down