Update BIP-352 status to Final #1737
Conversation
Changed the status of BIP-352 from Proposed to Final to reflect its acceptance and finalization. This update marks the completion of the review process and the formal acceptance of the proposal.
|
It might be a little early: the current status commit was in 9929215, this BIP was merged less than a year ago in #1458, and further updates may be found as developers implement it more widely. Please provide justification in the pull description for this proposed update based on the criteria enumerated in BIP 2, Section Progression to Final status. |
| @@ -5,7 +5,7 @@ | |||
| Author: josibake <[email protected]> | |||
| Ruben Somsen <[email protected]> | |||
| Comments-URI: https://github.com/bitcoin/bips/wiki/Comments:BIP-0352 | |||
| Status: Proposed | |||
| Status: Final | |||
There was a problem hiding this comment.
If this change moves forward, the README would need to be updated as well (in the same commit, and in this pull, not a new one)
|
Closing for now for the reasons in #1737 (comment). Happy to re-open at your request if you address the feedback. |
jonatack
added
the
PR Author action required
|
Just for the record, after taking a look here, I agree with @jonatack. BIP 352 doesn’t seem widely adopted yet, afaia there is only a single implementation, and especially the implementation the BIP’s authors are contributing to is still in progress, so moving it to final seems premature. |
|
I agree. I know Josie awaits an upstream PR merge to secp's library to handle all the cryptography heavy lifting, I just felt enough people who got the gist had already started shipping to production. e.g CakeWallet, DanaWallet, SeedSigner, Bitbox02. The cryptography Josie and Ruben put out is sound!!!!!!!! |
|
DanaWallet’s readme describes it as experimental, SeedSigner Silent Payment support seems to be an experiment Keith posted about on Twitter, but there are still open issues for it, and Bitbox only has sending support. While there definitely is some excitement and work is in progress, only CakeWallet has full support. 🤷 |
Changed the status of BIP-352 from Proposed to Final to reflect its acceptance and finalization. This update marks the completion of the review process and the formal acceptance of the proposal.