-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: associate MC photons in PhotoMultiplierHitDigi
output
#599
Conversation
Ready when new version of |
c56a28c
to
a4c55af
Compare
…rackerHitAssociation`
3ae5dd5
to
aa2a0de
Compare
Next commits will use the new MultiFactory |
90610a3
to
f68732e
Compare
Working on #612 to keep this cleaner. Doesn't work yet... |
Looks like all conversations are resolved. Let's wait til EDM4eic 2.0.0 makes it to the CVMFS image so the CI checks run. |
It builds... but poor scaling on a new build mechanism is causing the eic_container to eats its own tail in the scheduled nightly jobs... Working on that. |
|
CI passed, updating w.r.t. |
And confirmed these files are all identical to the ones on my |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just minor comments.
Briefly, what does this PR introduce?
Use
edm4eic::MCRecoTrackerHitAssociation
along withedm4eic::RawTrackerHit
, to include the MC photon information in the output ofPhotoMultiplierHitDigi
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
In general no breaking changes, but:
EDM4eic
is released, which includes datatypeMCRecoTrackerHitAssociation
, this will not build ineic-shell
Does this PR change default behavior?
only for the dRICH (the only user of
PhotoMultiplierHitDigi
)