feat: output raw hits and associations from PhotomultiplierHitDigi
#612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
NOTE: off topic of this PR, but this will minimize diffs with the `irt-algo` branch while we continue to factorize it into smaller PRs
c-dilks
force-pushed
the
pmt-associations-collections
branch
from
695c32e to
4faae12
Compare
|
Ready for review, but CI checks won't run yet until EDM4eic v2.0.0 is in the image. |
|
Hold up, found a bug |
Fixed by the removal of another pesky raw pointer. Downstream IRT code is confirmed to be fully functional with this PR. |
wdconinc
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
NOTE: This PR targets the branch associated with #599, and therefore adds on to it.
JMultifactoryfeaturestruct PhotoMultiplierHitDigiResultis used as the return value ofAlgorithmProcess(rather than astd::pair, for better flexibility and readability)std::vectors of raw pointers to PODIO collectionsDRICH.ccto be more consistent with feat!: add IRT PID to DRICH plugin #393 (we are factorizing that giant PR into smaller PRs, and these changes will make this process a bit easier)What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
no
Does this PR change default behavior?
no