Fix ArgumentError when calling dup on aggregations #1090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 CLA has been signed |
I have signed the Contributor Agreement but this won't go away |
rafayqayyum
force-pushed
the
fix-dup-on-es-aggregations
branch
from
a976b7c to
c926e7a
Compare
|
This bug is preventing us from upgrading the @picandocodigo are you able to assist us here? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where calling .dup on aggregations in elasticsearch-rails results in the following error:
ArgumentError Exception: wrong number of arguments (given 2, expected 0..1)
Testing
Verified that .dup now works correctly on aggregations.
Ensured no breaking changes in existing functionality.