Skip to content

Fix ArgumentError when calling dup on aggregations #1090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix ArgumentError when calling dup on aggregations #1090

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion elasticsearch-model/lib/elasticsearch/model/response/aggregations.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ module Response
class Aggregations < HashWrapper
disable_warnings if respond_to?(:disable_warnings)

def initialize(attributes={})
def initialize(attributes={}, options= {})
__redefine_enumerable_methods super(attributes)
end

Expand Down
7 changes: 7 additions & 0 deletions elasticsearch-model/spec/elasticsearch/model/response/aggregations_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,4 +80,11 @@ def self.index_name; 'foo'; end
expect(aggregations.price.max.value).to eq(99)
end
end

describe '#dup' do

it 'creates a copy of the aggregation' do
expect(aggregations.dup).to eq(aggregations)
end
end
end