Don't intern leafName in Mapper.Builder #119554
Merged
+2
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We shouldn't intern in the builder already. It's redundant since we'll be interning the mapper name when we actually build the mapper instance anyway and introduces a non-trivial slowdown into mapper serialization because we create temporary builders during serialization that never turn into concrete instances.
original-brownbear
added
>non-issue
:Search Foundations/Mapping
elasticsearchmachine
added
v9.0.0
Team:Search Foundations
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
javanna
approved these changes
Jan 6, 2025
original-brownbear
added
auto-backport
|
Thanks Luca! |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Jan 6, 2025
We shouldn't intern in the builder already. It's redundant since we'll be interning the mapper name when we actually build the mapper instance anyway and introduces a non-trivial slowdown into mapper serialization because we create temporary builders during serialization that never turn into concrete instances.
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 6, 2025
We shouldn't intern in the builder already. It's redundant since we'll be interning the mapper name when we actually build the mapper instance anyway and introduces a non-trivial slowdown into mapper serialization because we create temporary builders during serialization that never turn into concrete instances.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't intern in the builder already.
It's redundant since we'll be interning the mapper name when we actually build the mapper instance anyway and introduces a non-trivial slowdown into mapper serialization because we create temporary builders during serialization that never turn into concrete instances.