Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] Don't intern leafName in Mapper.Builder (#119554) #119603

Merged
merged 1 commit into from
Jan 6, 2025
Merged

[8.x] Don't intern leafName in Mapper.Builder (#119554) #119603

merged 1 commit into from
Jan 6, 2025

Conversation

original-brownbear
Copy link
Member

Backports the following commits to 8.x:

@original-brownbear
Don't intern leafName in Mapper.Builder (elastic#119554)
1d2a9c0 
We shouldn't intern in the builder already.
It's redundant since we'll be interning the mapper name
when we actually build the mapper instance anyway and introduces a
non-trivial slowdown into mapper serialization because we create
temporary builders during serialization that never turn into
concrete instances.
@original-brownbear original-brownbear added :Search Foundations/Mapping Index mappings, including merging and defining field types >non-issue auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch labels Jan 6, 2025
@elasticsearchmachine elasticsearchmachine mentioned this pull request Jan 6, 2025
Merged
@elasticsearchmachine elasticsearchmachine merged commit 8daac20 into elastic:8.x Jan 6, 2025
15 checks passed
@original-brownbear original-brownbear deleted the backport/8.x/pr-119554 branch January 6, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport >non-issue :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch v8.18.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@original-brownbear @elasticsearchmachine