[BREAKING] Add .root() and make shallow() and mount() semantics consistent #1107
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to: @ljharb
This PR updates both
mount()
andshallow()
to have similar semantics with respect to what the wrapper that is returned by them.The idea is that
mount(<Foo />)
andshallow(<Foo />)
both return a wrapper that's around the node that Foo rendered, and not<Foo />
itself. This means that calling.type()
and.instance()
on the resulting wrapper will not returnFoo
and an instance ofFoo
, but the type and instance of the root node returned by it's render function.Additionally, calling
.root()
on the wrapper will return a new wrapper that is around the node of<Foo />
. Calling.type()
on this wrapper will returnFoo
and.instance()
will return theFoo
component instance.This is a huge breaking change, and i'm not convinced that this is the right API. But putting up this PR for comments.