Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(styles) deprecate space export and add space to theme #75912

Draft
wants to merge 7 commits into
base: jb/theme/space
Choose a base branch
from
Draft

ref(styles) deprecate space export and add space to theme #75912

wants to merge 7 commits into from

Conversation

JonasBa
Copy link
Member

@JonasBa JonasBa commented Aug 9, 2024 •
edited
Loading

Mods all instances where space() is used inside a styled call. After this, there are ~70 changes where space is called like so that need to be changed.
CleanShot 2024-08-09 at 12 20 47@2x

@JonasBa JonasBa changed the base branch from master to jb/theme/space August 9, 2024 16:15
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Aug 9, 2024
@JonasBa JonasBa force-pushed the jb/theme/mod-space-literal branch from f42c86d to 7d79087 Compare August 9, 2024 16:51
@codecov Codecov
Copy link

codecov bot commented Aug 9, 2024 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 10.32kB ⬆️

Bundle name Size Change
app-webpack-bundle-array-push 29.52MB 10.32kB ⬆️

@codecov Codecov
Copy link

codecov bot commented Aug 9, 2024 •
edited
Loading

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
7656 2 7654 0
View the top 2 failed tests by shortest run time 
AlertRuleDetails displays EventUniqueUserFrequencyCondition count�AlertRuleDetails displays EventUniqueUserFrequencyCondition count
Stack Traces | 0.006s run time 
Error: expect(element).toHaveTextContent()

Expected element to have text content:
  Number of users affected by an issue is more than 89 in 1d
Received:
  Number of users affected by an issue ismore than 89 in 1d
    at Object.<anonymous> (.../issue/details/textRule.spec.tsx:64:31)
    at Promise.then.completed (.../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at _runTest (.../jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9)
    at run (.../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)
    at Object.worker (.../jest-runner/build/testWorker.js:106:12)
AlertRuleDetails displays EventFrequencyCondition percentage�AlertRuleDetails displays EventFrequencyCondition percentage
Stack Traces | 0.027s run time 
Error: expect(element).toHaveTextContent()

Expected element to have text content:
  Number of events in an issue is more than 1000 in 1h
Received:
  Number of events in an issue ismore than 1000 in 1h
    at Object.<anonymous> (.../issue/details/textRule.spec.tsx:20:31)
    at Promise.then.completed (.../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at _runTest (.../jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9)
    at run (.../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)
    at Object.worker (.../jest-runner/build/testWorker.js:106:12)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@JonasBa JonasBa force-pushed the jb/theme/mod-space-literal branch from 3b2b187 to ef20f80 Compare August 9, 2024 17:14
@JonasBa
ref(space) codemod for tempate literal
6791622 
update mod

execute changes

execute changes

remove unused imports

ref: remove codemod

lint and fix

:hammer_and_wrench: apply pre-commit fixes

fix
@JonasBa JonasBa force-pushed the jb/theme/mod-space-literal branch from 967d72f to 6791622 Compare August 9, 2024 17:27
@getsantry
Copy link
Contributor

getsantry bot commented Sep 5, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added Stale and removed Stale labels Sep 5, 2024
@getsantry
Copy link
Contributor

getsantry bot commented Sep 28, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added Stale and removed Stale labels Sep 28, 2024
@getsantry
Copy link
Contributor

getsantry bot commented Oct 21, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added Stale and removed Stale labels Oct 21, 2024
@getsantry
Copy link
Contributor

getsantry bot commented Nov 12, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added Stale and removed Stale labels Nov 12, 2024
@getsantry
Copy link
Contributor

getsantry bot commented Dec 5, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added Stale and removed Stale labels Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JonasBa