Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(styles) deprecate space export and add space to theme #75912

Draft
wants to merge 7 commits into
base: jb/theme/space
Choose a base branch
from
Draft
Prev Previous commit
Next Next commit
Merge branch 'jb/theme/space' into jb/theme/mod-space-literal
  • Loading branch information
JonasBa committed Aug 14, 2024
commit 3bef946ff0dcfd7d04fa108a49581ac42813d68d
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,7 @@ const Subtitle = styled('p')`

const Timestamp = styled('div')`
margin-right: ${p => p.theme.space(1)};
text-align: right;
color: ${p => p.theme.subText};
font-size: ${p => p.theme.fontSizeSmall};
span {
Expand Down
15 changes: 7 additions & 8 deletions static/app/components/timeline/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -62,12 +62,11 @@ const Row = styled('div')<{showLastLine?: boolean}>`
position: relative;
color: ${p => p.theme.subText};
align-items: start;
grid-template: auto auto / 22px 1fr auto;
grid-column-gap: ${p => p.theme.space(1)};
margin: ${p => p.theme.space(1)} 0;
&:first-child {
margin-top: 0;
}
display: grid;
grid-template-columns: subgrid;
grid-column: 1/-1;
grid-row-gap: ${p => p.theme.space(0.5)};

&:last-child {
/* Show/hide connecting line from the last element of the timeline */
background: ${p => (p.showLastLine ? 'transparent' : p.theme.background)};
Expand Down Expand Up @@ -135,8 +134,8 @@ export const Container = styled('div')`
position: relative;
display: grid;
grid-template: auto auto / 22px 1fr auto;
grid-row-gap: ${space(1)};
grid-column-gap: ${space(1)};
grid-row-gap: ${p => p.theme.space(1)};
grid-column-gap: ${p => p.theme.space(1)};
/* vertical line connecting items */
&::before {
content: '';
Expand Down
6 changes: 5 additions & 1 deletion static/app/views/organizationStats/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,11 @@ import {DATA_CATEGORY_INFO, DEFAULT_STATS_PERIOD} from 'sentry/constants';
import {ALL_ACCESS_PROJECTS} from 'sentry/constants/pageFilters';
import {t, tct} from 'sentry/locale';
import ConfigStore from 'sentry/stores/configStore';
import type {DataCategoryInfo, PageFilters} from 'sentry/types/core';
import {
DataCategoryExact,
type DataCategoryInfo,
type PageFilters,
} from 'sentry/types/core';
import type {Organization} from 'sentry/types/organization';
import type {Project} from 'sentry/types/project';
import withOrganization from 'sentry/utils/withOrganization';
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.