[mbedTLS] Integrate TLS handshake defragmentation PR #103247
Merged
+542
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Faless
force-pushed
the
mbedtls/backport_defragment_tls_handshake
branch
from
c7818c6 to
af0bc17
Compare
akien-mga
approved these changes
Feb 24, 2025
Comment on lines
+35
to
+37
| #ifdef TOOLS_ENABLED | ||
| #include "editor/editor_settings.h" | ||
| #endif // TOOLS_ENABLED |
There was a problem hiding this comment.
Technically not editor code shouldn't include editor headers (see #53295), but we have quite a few exceptions.
In this case I don't see any easy way to avoid this, it would need to be passed as a argument from where mbedtls is used in the editor, and that seems worse than allowing this exception.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream PR Mbed-TLS/mbedtls#9981 has been merged.
Fixes #101910 while leaving TLS 1.3 support by default.
Added an extra commit to enable TLSv1.3 support by default for editor and project by default.