Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

Commit

Permalink
Version 1.1.0.
Browse files Browse the repository at this point in the history
  • Loading branch information
grz-gajda committed Nov 19, 2015
1 parent 3cf74c1 commit 5b51edc
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 5 deletions.
6 changes: 5 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@

__Author__: Grzegorz Gajda _<[email protected]>_

### Update v1.1.0

If you don't want to use `CURLConnection` class, I added built-in integration with [guzzlehttp/guzzle](https://github.com/guzzle/guzzle) package. Since version 1.1.0, default provider for HTTP connection is `GuzzleConnection` class.

### Basic usage

First, we need to create instance of `RegisterKey` object to verify our key. We can use `ComicVine` static class to make that object.
Expand Down Expand Up @@ -123,7 +127,7 @@ $response->setFieldList(['api_detail_url', 'aliases'])

### Extending

Looking on current state of package, you can write your own `Connection` class (must implement `interface Connection`) and `ResponseFormat` (must implement `interface ResponseFormat`).
Looking on current state of package, you can write your own `Connection` class (must implement `interface Connection`) and `ResponseFormat` (must implement `interface ResponseFormat`). We can use new `Connection` class in `ComicVine::register()` method and new `ResponseFormat` class in `setFormat` method.

### License

Expand Down
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
],
"time": "2015-11-10",
"license": "MIT",
"version": "v1.0.0",
"version": "v1.1.0",
"authors": [
{
"name": "grz-gajda",
Expand Down
2 changes: 1 addition & 1 deletion src/Api/Connection/GuzzleConnection.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
* Class GuzzleConnection
*
* @package ComicVine\Api\Connection
* @author Grzegorz Gajda <[email protected]>
* @author Grzegorz Gajda <[email protected]>
*/
class GuzzleConnection implements Connection
{
Expand Down
2 changes: 1 addition & 1 deletion src/Api/Controllers/ControllerQuery.php
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ class ControllerQuery
/**
* Connection instance.
*
* @var Connection
* @var \ComicVine\Api\Connection\Connection
*/
private $connection;

Expand Down
2 changes: 1 addition & 1 deletion tests/ControllerTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ class ControllerTest extends PHPUnit_Framework_TestCase
*
* @test
*/
public function getBatman()
public function getBatmanCurl()
{
$expectedString = '{\"error\":\"OK\",\"limit\":1,\"offset\":0,\"number_of_page_results\":1,\"number_of_total_results\":15,\"status_code\":1,\"results\":[{\"api_detail_url\":\"http:\/\/www.comicvine.com\/api\/character\/4005-1699\/\"}],\"version\":\"1.0\"}';

Expand Down

0 comments on commit 5b51edc

Please sign in to comment.