Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Save and Share..." option in the file menu #1084

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

cycomachead
Copy link
Collaborator

@cycomachead cycomachead commented Dec 23, 2015

This builds of @bromagosa's work. There is a now an item in the file menu
which when selected will save the current project to the cloud, then will
present the user with a text box to copy the URL.

This makes the following changes from what's currently in BettleBlocks:

  • If the project hasn't been saved yet, then show a save dialog box first
  • Presenting the URL is now done with a native morphic dialog box! Now that
    C&P works well, this looks much nicer. :)
  • Adds a new IDE method publicProjectURL = function (username, projectName)
    • This gives the public project URL. I'm probably going to use this to
      refactor some existing code for getting URLs later.

There are some TODO elements:

  • Definitely needs a thorough code review
  • The dialog box looks a bit off. I think I could use some pointers here...
  • Until we have context menus, we probably want some text to tell people
    how to copy text.
  • Don't make a cloud request for the "share" service if the project is
    already public
  • Update the browser's URL on successful sharing.

Deployed at http://snap.berkeley.edu/michael

@cycomachead
Copy link
Collaborator Author

Seenshot:
screen shot 2015-12-22 at 5 30 26 pm

@brianharvey Would be good to confirm any wording concerns. :)

@brianharvey
Copy link
Collaborator

Nihil obstat.

@cycomachead
Copy link
Collaborator Author

Nihil obstat.

I had to look that one up! 👍

@cycomachead
Copy link
Collaborator Author

Fixed the layout with the dialog box! There's now a scrollbar so you can see the whole URL.

screen shot 2015-12-23 at 1 28 21 am

@bromagosa
Copy link
Collaborator

Oh I'm so stealing this one!

@cycomachead
Copy link
Collaborator Author

Jens, have you had a chance to look at this? I couldn't get some help text to easily show up, though I was probably missing something obvious...

@jmoenig
Copy link
Owner

jmoenig commented Feb 24, 2016

nice! I'd like to play with it a little bit myself before pulling it into the main distro

@dekrain
Copy link
Contributor

dekrain commented May 23, 2016

How ++ block works ?

@Klortho
Copy link

Klortho commented Jun 12, 2016

Status? I think this would be a huge improvement -- any chance of getting it pulled soon?

@dekrain
Copy link
Contributor

dekrain commented Jul 7, 2016

I know now:

  1. Change spec of {change %var by %n} to {change %repRing by %n}
  2. Add block {%anyUE"val" ++}
  3. Add definition: {
    {change (val) by (1)}
    {report (call (val))}
    }
  4. =8D

@cycomachead
Copy link
Collaborator Author

@jmoenig @brianharvey

Any change of this being pulled?

@jmoenig
Copy link
Owner

jmoenig commented Oct 27, 2016

Let's leave this one open for now...

@cycomachead
Copy link
Collaborator Author

As far as I know, it's mostly ready to go - is there interest in merging this?

@brianharvey
Copy link
Collaborator

It says here there's a conflict in gui.js so at least you have to fix that... But fwiw yes, I'd love to see this feature. It's a small thing but annoying not having it.

@cycomachead
Copy link
Collaborator Author

Yeah.

I can fix that. There's no point in fixing things that won't get merged though. :)

Michael Ball
From my iPhone
michaelball.co

On Oct 27, 2016, at 4:57 PM, Brian Harvey [email protected] wrote:

It says here there's a conflict in gui.js so at least you have to fix that... But fwiw yes, I'd love to see this feature. It's a small thing but annoying not having it.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@cycomachead
Copy link
Collaborator Author

@jmoenig Any interest in putting this soon?

@Klortho
Copy link

Klortho commented Jan 4, 2017

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants