Merge pull request XRPLF#2236 from XRPLF/WietseWind-patch-1

Add WARNING for fixNFTokenRemint: breaking change!
jonathanlei · Nov 1, 2023 · 4e1449d · 4e1449d
2 parents 6ff396a + 8299910
commit 4e1449d
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/content/resources/known-amendments.md b/content/resources/known-amendments.md
@@ -688,6 +688,8 @@ Amendment `fixNFTokenRemint` would change the way NFT sequence numbers are const
 
 The amendment also introduces a new account deletion restriction. An account can only be deleted if `FirstNFTSequence` + `MintedNFTokens` + 256 is less than the current ledger sequence (256 was chosen as a heuristic restriction for account deletion and already exists in the account deletion constraint). Without this restriction, an NFT could still be re-minted under certain conditions.
 
+**Warning:** This is a **breaking change** for projects & tools relying on their own locally computed NFTokenID for minted tokens. If you have code to calculate NFTokenIDs, you must update it to match the new fomula. For an example of how to do so with backwards compatibility, see this [well known reference implementation in JavaScript](https://gist.github.com/N3TC4T/a20fb528931ed009ebdd708be4938748?permalink_comment_id=4738760#gistcomment-4738760).
+
 
 ### fixNonFungibleTokensV1_2
 [fixNonFungibleTokensV1_2]: #fixnonfungibletokensv1_2