Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] mod articles #44475

Merged
merged 5 commits into from
Nov 27, 2024
Merged

[5.2] mod articles #44475

merged 5 commits into from
Nov 27, 2024

Conversation

brianteeman
Copy link
Contributor

Remove any images and empty anchor tags from the intro text

Pull Request for Issue #44474 .

Steps to reproduce the issue

Using the joomla sample data edit the article "joomla"
Add an image in the content and make the image a clickable link
View the source on the homepage for this article

Before PR

The module is set to hide article images so the image inserted will not be displayed
The image is removed but the link remains but is not actionable as the content for the link (the image) has been removed

Image

After PR

The image and the empty link are removed

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Remove any images and empty anchor tags from the intro text

Signed-off-by: BrianTeeman <[email protected]>
Signed-off-by: BrianTeeman <[email protected]>
This reverts commit f0f4a33b9cd4e14539be571eefe572dcc353efb5.
Signed-off-by: BrianTeeman <[email protected]>
@fgsw
Copy link

fgsw commented Nov 19, 2024

I have tested this item ✅ successfully on 22d882e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44475.

@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 7d6c94a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44475.

@Quy
Copy link
Contributor

Quy commented Nov 20, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44475.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 20, 2024
@Hackwar Hackwar added the bug label Nov 23, 2024
@Hackwar Hackwar merged commit e9296a3 into joomla:5.2-dev Nov 27, 2024
4 checks passed
@Hackwar Hackwar added this to the Joomla! 5.2.3 milestone Nov 27, 2024
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 27, 2024
@Hackwar
Copy link
Member

Hackwar commented Nov 27, 2024

Thank you for your contribution!

@brianteeman
Copy link
Contributor Author

thanks

@brianteeman brianteeman deleted the articles_helper branch November 27, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants