Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): fix search query params by removing explicit uri encoding/de… #7404

Merged

Conversation

aabhas-sao
Copy link
Contributor

…coding

What changes are being made and why?

due to encodeURI it was double encoding %20 to %2520 so server was returning no results for more than one word query separated by space.

In vue router 4 encoding/decoding uri params is not necessary.

Screenshot 2025-02-14 at 4 51 32 PM

closes #7061


How the changes have been QAed?

I have tested the changes locally.

abc.mp4

Copy link
Member

@MilosPaunovic MilosPaunovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @aabhas-sao,

I've simplified your approach a bit, to fit this particular case we're trying to solve.

Thanks for all the work here! 🚀

@MilosPaunovic MilosPaunovic merged commit 45a9ea0 into kestra-io:develop Feb 19, 2025
@yuri1969
Copy link
Contributor

yuri1969 commented Feb 22, 2025

@MilosPaunovic EDIT: Please disregard this, I have been a victim of a caching issue. Sorry

It seems the fix PR was not applied correctly since de145fa reintroduces the redundant URI encoding of the label value.

At /ui/flows?scope=USER try to filter the flows by clicking on the label of the following flow:

id: rat_157618
namespace: company.team

labels:
  amp&: amp& # '&' shouldn't be encoded

tasks:
  - id: hello
    type: io.kestra.plugin.core.log.Log
    message: Hello World! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Blueprints search works only when typing 1 word
3 participants