Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): fix search query params by removing explicit uri encoding/de… #7404

Merged
merged 3 commits into from
Feb 19, 2025
Merged

fix(ui): fix search query params by removing explicit uri encoding/de… #7404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
292a80f
fix(ui): fix search query params by removing explicit uri encoding/de…
aabhas-sao Feb 14, 2025
4dd6874
Merge branch 'develop' into fix/kestra-filter-space-in-search
MilosPaunovic Feb 19, 2025
de145fa
chore(ui): simplify query search with spaces inside
MilosPaunovic Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ui/src/components/filter/components/Label.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
const UNKNOWN = "unknown";
const label = computed(() => props.option.label);
const operation = computed(() => props.option?.operation || props.option?.comparator?.value);
const operation = computed(() => props.option?.operation ?? props.option?.comparator?.value ?? (props.option?.label === "text" ? "$eq" : undefined));
const value = computed(() => {
const {value, label, operation} = props.option;
Expand Down
6 changes: 3 additions & 3 deletions ui/src/components/filter/utils/helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ export const encodeParams = (route, filters, OPTIONS) => {
const encode = (values, key) => {
return values
.map((v) => {
if (key === "childFilter" && v === "ALL") {
return null;
}
if (key === "childFilter" && v === "ALL") return null;
else if(key === "q") return v;

const encoded = encodeURIComponent(v);
return key === "labels"
? encoded.replace(/%3A/g, ":")
Expand Down