Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add meta_programming.html #25

Closed

Conversation

denver411
Copy link

#2

@denver411 denver411 added the WIP label Jul 3, 2018
@denver411 denver411 added this to the 1 - Pages milestone Jul 3, 2018
@denver411 denver411 self-assigned this Jul 3, 2018
@denver411 denver411 requested a review from khusnetdinov July 3, 2018 15:30
@denver411 denver411 changed the title add gaps add meta_programming.html Jul 3, 2018
Copy link
Owner

@khusnetdinov khusnetdinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Несколько первых блоков построчно указал что удалить. Обрати внимание на пробельные строки, как и где они должны быть. Выравнивание кода. И где должны идти коментариии. По аналогии с первыми блоками поправивить надо и другие.


# => 3

{% endhighlight %}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

26, 28, 33, 35, 37 пробельные строки убрать

foo = Foo.new('world')
foo.world # => "hello world!"

{% endhighlight %}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

50, 61, 64, 72, 79, 83, 87, 92 пробельные строки убрать

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

59, 60, 78-92, 113-118, 125, 126 выровять относительно class (2 пробела от левой границы)


# => You also passed a block

{% endhighlight %}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

140, 153 удалить пробельный строки

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

148 - 150 два пробела от левой границы и выравнивание по классу

# you can utilise the "Dynamic Method" technique to create a real method after
# the message has been received by `method_missing` the first time.

{% endhighlight %}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

169, 178 пробельные строки

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

175-178 выравнивание 2 пробела

# rest of your code (such as your "Dynamic Proxy" implementation)
end

{% endhighlight %}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

200, 208 пробельные строки удалить

@khusnetdinov
Copy link
Owner

@denver411

@khusnetdinov
Copy link
Owner

Closed by other PR #29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants