[pull] master from GNOME:master #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Resolves #12854 Previously when loading filters, we used gimp_drawable_filter_apply (). If there was also an active selection, it affected the recreation of the filter and distorted the display. This patch switches to using gimp_drawable_filter_apply_with_mask () so that the filter's mask is always used instead, no matter if there is an active selection or not.
This is markup format where the asterisk has some special meaning.
In particular, when setting a sensitivity mask but no image types, the procedure was always sensitive. Also make gimp_plug_in_procedure_get_sensitive() more robust.
After discussing with NikcDC and Wormnest on IRC, we agreed that maybe a default of being sensitive when one or more drawables are selected seems better, since the run() signature now has an array of drawables. So most plug-in developers will consider the case when there are several selected drawables as an obvious possible case. And if someone really doesn't want to handle this case, they can always set the sensitivity mask explicitly.
As discussed on IRC these ops mostly duplicate other gegl ops and have some shortcomings: range and gui-range, among other things, are currently not supported. This causes some issues changing values of parameters in GIMP, see e.g. https://gitlab.gnome.org/GNOME/gegl/-/issues/403 Since they bring nothing new, and have issues, we will blacklist them from the GEGL tools interface in GIMP, at least until they have better support in GEGL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )