Add windows node graceful shutdown doc #48474

zylxjtu · 2024-10-21T17:19:28Z

Description

Issue

kubernetes/enhancements#4802
code PR:
kubernetes/kubernetes#127404

Closes: #

linux-foundation-easycla · 2024-10-21T17:19:32Z

The committers listed above are authorized under a signed CLA.

✅ login: zylxjtu / name: yuanliang (e4bdcbc)

netlify · 2024-10-21T17:20:06Z

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name	Link
🔨 Latest commit	`e4bdcbc`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/673c230fb9eaf600086771ff

netlify · 2024-10-21T17:34:00Z

✅ Pull request preview available for checking

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`e4bdcbc`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/673c230f331ff400087ca19d
😎 Deploy Preview	https://deploy-preview-48474--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

chanieljdan · 2024-11-06T00:57:03Z

Hi @zylxjtu 👋

Just a reminder to take a look at Documenting for a release - PR Ready for Review to get your PR ready for review ahead of the "Ready for Review" deadline on Tuesday November 19th 2024 18:00 PST.

Thank you!

Arhell

/easycla

jsturtevant · 2024-11-18T20:57:19Z

.../docs/reference/command-line-tools-reference/feature-gates/windows-graceful-node-shutdown.md

+  - stage: beta
+    defaultValue: true
+    fromVersion: "1.33"


I don't think we want this in here, until we get to the 1.33 release and make a decision on this in the KEP

jsturtevant · 2024-11-18T20:58:33Z

content/en/docs/concepts/cluster-administration/node-shutdown.md

+
+If Kubelet is not running as a Windows service, it will not be able to set and monitor 
+the [Preshutdown](https://learn.microsoft.com/en-us/windows/win32/api/winsvc/ns-winsvc-service_preshutdown_info) event,
+the node will have to  go through the [Non-Graceful Node Shutdown](#non-graceful-node-shutdown) procedure mentioned above.


Suggested change

the node will have to go through the [Non-Graceful Node Shutdown](#non-graceful-node-shutdown) procedure mentioned above.

the node will have to go through the [Non-Graceful Node Shutdown](#non-graceful-node-shutdown) procedure mentioned above.

Will the user get a log? Will kubelet fail or will it silently continue on in this case?

tengqm · 2024-11-19T00:35:12Z

.../docs/reference/command-line-tools-reference/feature-gates/windows-graceful-node-shutdown.md

+  - stage: alpha
+    defaultValue: false
+    fromVersion: "1.32"
+    toVersion: "1.32"


Remove this line.

you mean these 4 lines or the line 12?

This feature will not go away by the end of 1.32, right?
So line 12 should be removed.

content/en/docs/concepts/cluster-administration/node-shutdown.md

tengqm · 2024-11-19T00:36:46Z

content/en/docs/concepts/cluster-administration/node-shutdown.md

+it will then have a registered [service control handler](https://learn.microsoft.com/en-us/windows/win32/services/service-control-handler-function) 
+to delay the  presshutdown event with a given duration.
+
+Windows graceful node shutdown is controlled with the `WindowsGracefulNodeShutdown` [feature gate](/docs/reference/command-line-tools-reference/feature-gates/) 


Suggested change

Windows graceful node shutdown is controlled with the `WindowsGracefulNodeShutdown` [feature gate](/docs/reference/command-line-tools-reference/feature-gates/)

Windows graceful node shutdown is controlled with the `WindowsGracefulNodeShutdown`

[feature gate](/docs/reference/command-line-tools-reference/feature-gates/)

will update, just wondering what the visual difference will be?

From the perspective of the rendered HTML, nothing is different.
From the perspective of docs "source", we discourage long lines, because git diff works
on a line-by-line comparison basis. Changes to long lines are difficult to figure out
thus are difficult to review. For downstream localization teams, they need to track the
upstream changes on a line by line basis. Long lines make their lives suck.

tengqm · 2024-11-19T13:34:26Z

/approve
Considering that the upstream code has landed.

k8s-ci-robot · 2024-11-19T13:34:39Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~content/en/docs/OWNERS~~ [tengqm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

marosset · 2024-11-19T17:09:14Z

/lgtm
/hold
in case @jsturtevant wants to re-review

k8s-ci-robot · 2024-11-19T17:09:22Z

LGTM label has been added.

Git tree hash: b023a62ff23b7a5968106914519284cef03a8a7d

marosset · 2024-11-19T17:11:00Z

/sig windows
/sig node

jsturtevant · 2024-11-21T23:01:40Z

/hold cancel

carlory · 2024-12-06T07:29:57Z

content/en/docs/concepts/cluster-administration/node-shutdown.md

+
+Windows graceful node shutdown is controlled with the `WindowsGracefulNodeShutdown` 
+[feature gate](/docs/reference/command-line-tools-reference/feature-gates/) 
+which is introduced in 1.32 as an alpha feature.


Hi @zylxjtu, @SergeyKanzhelev If a user wants to use this feature, the GracefulNodeShutdown and WindowsGracefulNodeShutdown feature-gate must be turned on together. Is it correct?

https://github.com/carlory/kubernetes/blob/master/pkg/kubelet/apis/config/validation/validation.go#L178

no, depends on which platform are you on, you only need to enable one of them

That sounds like a bug. If GracefulNodeShutdown is false, the kubelet shouldn't provide graceful node shutdown.

(or, we should document that the feature gate is misnamed and ought to be treated as if it were named LinuxGracefulNodeShutdown).

k8s-ci-robot added this to the 1.32 milestone Oct 21, 2024

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 21, 2024

k8s-ci-robot requested a review from dipesh-rawat October 21, 2024 17:19

k8s-ci-robot added the language/en Issues or PRs related to English language label Oct 21, 2024

k8s-ci-robot requested a review from windsonsea October 21, 2024 17:19

k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 21, 2024

zylxjtu mentioned this pull request Oct 21, 2024

Windows node gracefully shutdown kubernetes/enhancements#4802

Open

5 tasks

Arhell reviewed Nov 9, 2024

View reviewed changes

zylxjtu force-pushed the dev-1.32 branch from b9505ad to a94d1b7 Compare November 14, 2024 18:39

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 14, 2024

zylxjtu force-pushed the dev-1.32 branch 2 times, most recently from 63fe604 to 8833042 Compare November 14, 2024 18:47

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 14, 2024

zylxjtu marked this pull request as ready for review November 14, 2024 18:48

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 14, 2024

zylxjtu requested a review from Arhell November 14, 2024 18:48

k8s-ci-robot requested review from natalisucks and salaxander November 14, 2024 18:49

zylxjtu changed the title ~~Add windows node graceful shutdown doc (draft)~~ Add windows node graceful shutdown doc Nov 14, 2024

zylxjtu force-pushed the dev-1.32 branch from 8833042 to 5c2472d Compare November 14, 2024 19:17

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 14, 2024

jsturtevant reviewed Nov 18, 2024

View reviewed changes

zylxjtu force-pushed the dev-1.32 branch from 5c2472d to f7f9db1 Compare November 18, 2024 23:16

zylxjtu requested a review from jsturtevant November 18, 2024 23:18

tengqm reviewed Nov 19, 2024

View reviewed changes

Add the windows graceful node shutdown doc

e4bdcbc

zylxjtu force-pushed the dev-1.32 branch from f7f9db1 to e4bdcbc Compare November 19, 2024 05:33

zylxjtu requested a review from tengqm November 19, 2024 05:33

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2024

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 19, 2024

k8s-ci-robot assigned marosset Nov 19, 2024

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 19, 2024

k8s-ci-robot added sig/windows Categorizes an issue or PR as relevant to SIG Windows. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Nov 19, 2024

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 21, 2024

k8s-ci-robot merged commit 5ea7951 into kubernetes:dev-1.32 Nov 21, 2024
6 checks passed

carlory reviewed Dec 6, 2024

View reviewed changes

carlory mentioned this pull request Dec 17, 2024

Fix WindowsGracefulNodeShutdown: shouldn't depend on GracefulNodeShutdown kubernetes/kubernetes#129245

Open

Eason1118 mentioned this pull request Dec 17, 2024

[zh-cn] Sync node-shutdown.md #49138

Closed

zylxjtu mentioned this pull request Feb 7, 2025

REQUEST: New membership for zylxjtu kubernetes/org#5391

Closed

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add windows node graceful shutdown doc #48474

Add windows node graceful shutdown doc #48474

zylxjtu commented Oct 21, 2024 •

edited

Loading

linux-foundation-easycla bot commented Oct 21, 2024 •

edited

Loading

netlify bot commented Oct 21, 2024 •

edited

Loading

netlify bot commented Oct 21, 2024 •

edited

Loading

chanieljdan commented Nov 6, 2024

Arhell left a comment

jsturtevant Nov 18, 2024

zylxjtu Nov 18, 2024

jsturtevant Nov 18, 2024

jsturtevant Nov 18, 2024

zylxjtu Nov 18, 2024

tengqm Nov 19, 2024

zylxjtu Nov 19, 2024

tengqm Nov 19, 2024

tengqm Nov 19, 2024

zylxjtu Nov 19, 2024

tengqm Nov 19, 2024

tengqm commented Nov 19, 2024

k8s-ci-robot commented Nov 19, 2024

marosset commented Nov 19, 2024

k8s-ci-robot commented Nov 19, 2024

marosset commented Nov 19, 2024

jsturtevant commented Nov 21, 2024

carlory Dec 6, 2024 •

edited

Loading

carlory Dec 6, 2024

zylxjtu Dec 14, 2024

sftim Dec 16, 2024

	the node will have to go through the [Non-Graceful Node Shutdown](#non-graceful-node-shutdown) procedure mentioned above.
	the node will have to go through the [Non-Graceful Node Shutdown](#non-graceful-node-shutdown) procedure mentioned above.

	Windows graceful node shutdown is controlled with the `WindowsGracefulNodeShutdown` [feature gate](/docs/reference/command-line-tools-reference/feature-gates/)
	Windows graceful node shutdown is controlled with the `WindowsGracefulNodeShutdown`
	[feature gate](/docs/reference/command-line-tools-reference/feature-gates/)

Add windows node graceful shutdown doc #48474

Add windows node graceful shutdown doc #48474

Conversation

zylxjtu commented Oct 21, 2024 • edited Loading

Description

Issue

linux-foundation-easycla bot commented Oct 21, 2024 • edited Loading

netlify bot commented Oct 21, 2024 • edited Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

netlify bot commented Oct 21, 2024 • edited Loading

✅ Pull request preview available for checking

chanieljdan commented Nov 6, 2024

Arhell left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tengqm commented Nov 19, 2024

k8s-ci-robot commented Nov 19, 2024

marosset commented Nov 19, 2024

k8s-ci-robot commented Nov 19, 2024

marosset commented Nov 19, 2024

jsturtevant commented Nov 21, 2024

carlory Dec 6, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zylxjtu commented Oct 21, 2024 •

edited

Loading

linux-foundation-easycla bot commented Oct 21, 2024 •

edited

Loading

netlify bot commented Oct 21, 2024 •

edited

Loading

netlify bot commented Oct 21, 2024 •

edited

Loading

carlory Dec 6, 2024 •

edited

Loading