-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add windows node graceful shutdown doc #48474
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add the windows graceful node shutdown doc
- Loading branch information
commit e4bdcbcf5bc3446f2f3ff6b6dc45c08a43e6600b
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 18 additions & 0 deletions
18
...ce/command-line-tools-reference/feature-gates/windows-graceful-node-shutdown.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
--- | ||
title: WindowsGracefulNodeShutdown | ||
content_type: feature_gate | ||
_build: | ||
list: never | ||
render: false | ||
|
||
stages: | ||
- stage: alpha | ||
defaultValue: false | ||
fromVersion: "1.32" | ||
|
||
--- | ||
Enables support for windows node graceful shutdown in kubelet. | ||
During a system shutdown, kubelet will attempt to detect the shutdown event | ||
and gracefully terminate pods running on the node. See | ||
[Graceful Node Shutdown](/docs/concepts/architecture/nodes/#graceful-node-shutdown) | ||
for more details. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @zylxjtu, @SergeyKanzhelev If a user wants to use this feature, the GracefulNodeShutdown and WindowsGracefulNodeShutdown feature-gate must be turned on together. Is it correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/carlory/kubernetes/blob/master/pkg/kubelet/apis/config/validation/validation.go#L178
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, depends on which platform are you on, you only need to enable one of them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds like a bug. If
GracefulNodeShutdown
is false, the kubelet shouldn't provide graceful node shutdown.(or, we should document that the feature gate is misnamed and ought to be treated as if it were named
LinuxGracefulNodeShutdown
).