Create activity endpoint for bad practice detection #224

iam-flo · 2025-01-17T17:16:45Z

Motivation

We create a dashboard that displays current pull requests together with detected bad practices

Description

Create an activity endpoint to get and detect bad practices in PRs.
Visualize PRs and bad practices in a dashboard

Testing Instructions

Run application server and client.
Access: http://localhost:4200/activity/iam-flo

Screenshots (if applicable)

General

PR title is clear and descriptive
PR description explains the purpose and changes
Code follows project coding standards
Self-review of the code has been done
Changes have been tested locally
Screenshots have been attached (if applicable)

Client (if applicable)

UI changes look good on all screen sizes and browsers
No console errors or warnings
User experience and accessibility have been tested
Added Storybook stories for new components
Components follow design system guidelines (if applicable)

Server (if applicable)

Code is performant and follows best practices
No security vulnerabilities introduced
Proper error handling has been implemented

Summary by CodeRabbit

New Features
- Introduced new API endpoints to track user activity and detect pull request issues.
- Launched an Activity Dashboard for admin users, displaying open pull requests and identified issues.
- Added new UI components, including activity cards and bad practice cards, along with an updated header link and routing, enhancing access to activity details.
- Introduced a new method for formatting titles in the UI for improved presentation.

webapp/src/app/app.routes.ts

FelixTJDietrich

Here are some comments, you can also create follow-up issues and fix stuff there for some parts. Generally looks good though :)

FelixTJDietrich · 2025-02-19T17:12:43Z

server/application-server/src/main/java/de/tum/in/www1/hephaestus/activity/ActivityService.java

+        return new ActivityDTO(openPullRequestsWithBadPractices);
+    }
+
+    @Transactional


Do we need this here? Usually we should not make use of @Transactional only in rare cases

Otherwise we get an error because of LOB access.

FelixTJDietrich · 2025-02-19T17:13:02Z

server/application-server/src/main/java/de/tum/in/www1/hephaestus/activity/ActivityService.java

+    @Autowired
+    private UserRepository userRepository;
+
+    @Transactional


Do we need @Transactional?

I think so because of LOB access. Maybe we could move it into the repository access methods.

FelixTJDietrich · 2025-02-19T17:14:09Z

.../application-server/src/main/java/de/tum/in/www1/hephaestus/activity/ActivityController.java

+    }
+
+    @PostMapping("/{login}/badpractices")
+    public ResponseEntity<List<PullRequestBadPracticeDTO>> detectBadPracticesByUser(@PathVariable String login) {


We are not doing any access checks, I guess any unauthorized user could post to that endpoint in theory. Is that intended?

Not necessarily intended but also not an issue I think, since no data is passed along. We could protect it though, what do you think?

FelixTJDietrich · 2025-02-19T17:15:41Z

...on-server/src/main/java/de/tum/in/www1/hephaestus/activity/model/PullRequestBadPractice.java

+    @JoinColumn(name = "pullrequest_id")
+    private PullRequest pullrequest;
+
+    private boolean resolved;


This could be a timestamp in the future, then we automatically know when the user pressed resolved

In the next PR this is set if the intelligence service marks the Bad practice as resolved. maybe for user resolved we add a new variable then?

FelixTJDietrich · 2025-02-19T17:18:03Z

...r/src/main/java/de/tum/in/www1/hephaestus/activity/model/PullRequestWithBadPracticesDTO.java

+        PullRequest pullRequest,
+        List<PullRequestBadPracticeDTO> badPractices
+    ) {
+        return new PullRequestWithBadPracticesDTO(


I think here we can do some better composition. I thought we have a base DTO for the pull request data that we are using for the activity card

The info dto contains data that we dont need for the dashboard, so I thought that creating a dto without would be a good practice. I can also use the existing one.

webapp/src/app/user/bad-practice-card/bad-practice-card.stories.ts

FelixTJDietrich · 2025-02-19T17:25:47Z

webapp/src/app/user/pull-request-bad-practice-card/pull-request-bad-practice-card.component.ts

+  state = input<PullRequestInfo.StateEnum>();
+  isDraft = input<boolean>();
+  isMerged = input<boolean>();
+  pullRequestLabels = input<Array<LabelInfo>>();


I think it is possible to just have one input for the pull request base info or so, instead of having an input for each field. I think I did it like this somewhere else.

the other components also use multiple inputs instead of a single one. what is best practice?

webapp/src/app/user/pull-request-bad-practice-card/pull-request-bad-practice-card.component.ts

coderabbitai · 2025-02-19T17:33:53Z

Walkthrough

This pull request introduces new API endpoints and data models for managing user activities and detecting pull request bad practices in the Hephaestus application. On the backend, several new services, controllers, repositories, and database migrations have been added or updated. On the frontend, Angular routes, components, OpenAPI service interfaces, and Storybook stories have been implemented to support an activity dashboard and related UI elements displaying bad practices in pull requests.

Changes

File(s)	Change Summary
`server/application-server/openapi.yaml`	Updated OpenAPI spec: added endpoints (`POST /activity/{login}/badpractices`, `GET /activity/{login}`) and new schemas (`Activity`, `PullRequestBadPractice`, `PullRequestWithBadPractices`).
`server/application-server/src/main/java/de/tum/in/www1/hephaestus/activity/**`	New Java components added: `ActivityController`, `ActivityService`, `PullRequestBadPracticeDetector`, repository interface (`PullRequestBadPracticeRepository`), and associated DTOs/records (`ActivityDTO`, `PullRequestBadPractice`, `PullRequestBadPracticeDTO`, `PullRequestWithBadPracticesDTO`).
`server/application-server/src/main/resources/db/changelog/1738063112622_changelog.xml` `server/application-server/src/main/resources/db/master.xml`	New Liquibase changelog for creating `pull_request_bad_practice` table and adding a foreign key constraint; updated master changelog includes.
`webapp/src/app/app.routes.ts` `webapp/src/app/core/header/header.component.html`	New Angular route for `ActivityDashboardComponent` and a header link to the user's activity page.
`webapp/src/app/core/modules/openapi/**`	Added OpenAPI-generated files: new activity service (`activity.service.ts`), service interface (`activity.serviceInterface.ts`), and models (`activity.ts`, `pull-request-bad-practice.ts`, `pull-request-with-bad-practices.ts`), plus updated API exports.
`webapp/src/app/home/activity/` `webapp/src/app/user/bad-practice-card/` `webapp/src/app/user/pull-request-bad-practice-card/**`	New Angular UI components and Storybook stories for the activity dashboard, bad practice cards, and pull request bad practice cards, providing displays for pull request details and detected bad practices.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant AC as ActivityController
    participant AS as ActivityService
    participant Repo as PullRequestBadPracticeRepository
    participant Detector as PullRequestBadPracticeDetector

    U->>AC: GET /activity/{login}
    AC->>AS: getActivity(login)
    AS->>Repo: Query pull requests & bad practices
    Repo-->>AS: Return data
    AS-->>AC: Construct and return ActivityDTO
    AC-->>U: HTTP 200 with ActivityDTO

sequenceDiagram
    participant U as User
    participant AC as ActivityController
    participant AS as ActivityService
    participant Detector as PullRequestBadPracticeDetector
    participant Repo as PullRequestBadPracticeRepository

    U->>AC: POST /activity/{login}/badpractices
    AC->>AS: detectBadPractices(login)
    AS->>Detector: Process pull requests for bad practices
    Detector->>Repo: Retrieve existing bad practices
    Repo-->>Detector: Return bad practices list
    Detector-->>AS: Send bad practices list
    AS-->>AC: Return list of PullRequestBadPracticeDTO
    AC-->>U: HTTP 200 with bad practices data

sequenceDiagram
    participant User as User
    participant ADC as ActivityDashboardComponent
    participant AS as Angular ActivityService (client)
    participant API as Hephaestus API

    User->>ADC: Navigate to Activity Dashboard
    ADC->>AS: getActivityByUser(login)
    AS->>API: GET /activity/{login}
    API-->>AS: Return Activity DTO
    AS-->>ADC: Provide activity data
    ADC->>User: Render dashboard with activity & bad practices info

Poem

Hoppity-hop, I’m a clever bunny,
Coding through changes with a skip and a funny,
New endpoints and dashboards, a digital delight,
Bad practices detected, making everything bright,
With routes and services, our code's on a run,
A crisp, fresh update under the coding sun!
🐇💻 Happy hops in every byte!

✨ Finishing Touches

📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 8

♻️ Duplicate comments (4)

server/application-server/src/main/java/de/tum/in/www1/hephaestus/activity/ActivityController.java (1)

17-21: ⚠️ Potential issue

Add error handling and access control.

Both endpoints need:

Access control to prevent unauthorized access
Error handling for service exceptions

     @GetMapping("/{login}")
     public ResponseEntity<ActivityDTO> getActivityByUser(@PathVariable String login) {
+        // Add authentication check
+        try {
             ActivityDTO activity = activityService.getActivity(login);
             return ResponseEntity.ok(activity);
+        } catch (Exception e) {
+            logger.error("Error getting activity for user {}: {}", login, e.getMessage());
+            return ResponseEntity.internalServerError().build();
+        }
     }

     @PostMapping("/{login}/badpractices")
     public ResponseEntity<List<PullRequestBadPracticeDTO>> detectBadPracticesByUser(@PathVariable String login) {
+        // Add authentication check
+        try {
             List<PullRequestBadPracticeDTO> badPractices = activityService.detectBadPractices(login);
             return ResponseEntity.ok(badPractices);
+        } catch (Exception e) {
+            logger.error("Error detecting bad practices for user {}: {}", login, e.getMessage());
+            return ResponseEntity.internalServerError().build();
+        }
     }

Also applies to: 23-27

webapp/src/app/home/activity/activity-dashboard.component.ts (1)

28-32: ⚠️ Potential issue

Add error handling for the activity query.

The query lacks error handling for cases where:

The user doesn't exist
The API request fails

Also, the 400ms timer delay needs justification or removal.

Consider implementing error handling like this:

   query = injectQuery(() => ({
     queryKey: ['user', { id: this.userLogin }],
     enabled: !!this.userLogin,
-    queryFn: async () => lastValueFrom(combineLatest([this.activityService.getActivityByUser(this.userLogin!), timer(400)]).pipe(map(([activity]) => activity)))
+    queryFn: async () => {
+      try {
+        return await lastValueFrom(this.activityService.getActivityByUser(this.userLogin!));
+      } catch (error) {
+        if (error.status === 404) {
+          throw new Error(`User ${this.userLogin} not found`);
+        }
+        throw error;
+      }
+    }
   }));

server/application-server/src/main/java/de/tum/in/www1/hephaestus/activity/model/PullRequestWithBadPracticesDTO.java (1)

12-26: 🛠️ Refactor suggestion

Consider using composition with a base PullRequest DTO.

The record contains many fields that appear to be common pull request data. Consider extracting these into a base DTO and composing with it to reduce duplication and improve maintainability.

Example refactor:

-public record PullRequestWithBadPracticesDTO(
-    @NonNull Long id,
-    @NonNull Integer number,
-    @NonNull String title,
-    @NonNull Issue.State state,
-    @NonNull Boolean isDraft,
-    @NonNull Boolean isMerged,
-    List<LabelInfoDTO> labels,
-    RepositoryInfoDTO repository,
-    @NonNull Integer additions,
-    @NonNull Integer deletions,
-    @NonNull String htmlUrl,
-    OffsetDateTime createdAt,
-    List<PullRequestBadPracticeDTO> badPractices
-) {
+public record PullRequestWithBadPracticesDTO(
+    @NonNull PullRequestBaseDTO pullRequest,
+    List<PullRequestBadPracticeDTO> badPractices
+) {

server/application-server/src/main/java/de/tum/in/www1/hephaestus/activity/ActivityService.java (1)

36-36: 🛠️ Refactor suggestion

Remove unnecessary @Transactional annotation.

The getActivity method is read-only and doesn't modify any data. The @Transactional annotation is unnecessary for read-only operations.
-    @Transactional
     public ActivityDTO getActivity(String login) {

🧹 Nitpick comments (12)

server/application-server/src/main/java/de/tum/in/www1/hephaestus/activity/model/ActivityDTO.java (1)
3-6: Consider using standard null safety annotations.

Replace io.micrometer.common.lang.NonNull with jakarta.validation.constraints.NotNull for better integration with Spring's validation framework and consistency with Jakarta EE standards.
-import io.micrometer.common.lang.NonNull;
+import jakarta.validation.constraints.NotNull;

-public record ActivityDTO(@NonNull List<PullRequestWithBadPracticesDTO> pullRequests) {}
+public record ActivityDTO(@NotNull List<PullRequestWithBadPracticesDTO> pullRequests) {}
server/application-server/src/main/java/de/tum/in/www1/hephaestus/activity/model/PullRequestBadPracticeDTO.java (1)
3-3: Add null safety annotations to fields.

Consider adding @NotNull annotations to the fields that should not be null. This helps with validation and provides better documentation of the contract.
-public record PullRequestBadPracticeDTO(String title, String description, boolean resolved) {
+public record PullRequestBadPracticeDTO(
+    @NotNull String title,
+    @NotNull String description,
+    boolean resolved) {
server/application-server/src/main/java/de/tum/in/www1/hephaestus/activity/ActivityController.java (1)
14-15: Use constructor injection instead of field injection.

Field injection using @Autowired is discouraged as it makes the class harder to test and hides dependencies.
-    @Autowired
-    private ActivityService activityService;
+    private final ActivityService activityService;
+
+    public ActivityController(ActivityService activityService) {
+        this.activityService = activityService;
+    }
server/application-server/src/main/java/de/tum/in/www1/hephaestus/activity/PullRequestBadPracticeRepository.java (2)
12-19: Optimize the JPQL query for findAssignedByLoginAndOpen.

The current query performs case-insensitive comparison using LOWER function on both sides, which can impact performance.
     @Query(
         """
         SELECT prbp
         FROM PullRequestBadPractice prbp
-        WHERE LOWER(:assigneeLogin) IN (SELECT LOWER(u.login) FROM prbp.pullrequest.assignees u) AND prbp.pullrequest.state = 'OPEN'
+        WHERE :assigneeLogin IN (
+            SELECT u.login FROM prbp.pullrequest.assignees u
+            WHERE LOWER(u.login) = LOWER(:assigneeLogin)
+        ) AND prbp.pullrequest.state = 'OPEN'
         """
     )
21-28: Replace custom query with derived query method.

The custom JPQL query for findByPullRequestId can be replaced with a derived query method.
-    @Query(
-        """
-        SELECT prbp
-        FROM PullRequestBadPractice prbp
-        WHERE prbp.pullrequest.id = :pullRequestId
-        """
-    )
-    List<PullRequestBadPractice> findByPullRequestId(@Param("pullRequestId") long pullRequestId);
+    List<PullRequestBadPractice> findByPullrequestId(long pullRequestId);
server/application-server/src/main/java/de/tum/in/www1/hephaestus/activity/badpracticedetector/PullRequestBadPracticeDetector.java (1)
17-18: Use constructor injection instead of field injection.

Field injection using @Autowired is discouraged as it makes the class harder to test and hides dependencies.
-    @Autowired
-    private PullRequestBadPracticeRepository pullRequestBadPracticeRepository;
+    private final PullRequestBadPracticeRepository pullRequestBadPracticeRepository;
+
+    public PullRequestBadPracticeDetector(PullRequestBadPracticeRepository pullRequestBadPracticeRepository) {
+        this.pullRequestBadPracticeRepository = pullRequestBadPracticeRepository;
+    }
webapp/src/app/core/modules/openapi/model/pull-request-with-bad-practices.ts (1)
17-31: Add JSDoc comments to document the interface properties.

While the interface is well-structured, adding JSDoc comments would improve code maintainability and developer experience.

Add documentation like this:
 export interface PullRequestWithBadPractices { 
+    /** Unique identifier of the pull request */
     id: number;
+    /** Pull request number in the repository */
     number: number;
+    /** Title of the pull request */
     title: string;
     // ... add similar comments for other properties
 }
webapp/src/app/core/modules/openapi/api/activity.serviceInterface.ts (1)
28-40: Improve method documentation with detailed JSDoc comments.

The method documentation is incomplete. Add comprehensive JSDoc comments including parameter descriptions and return value details.

Add documentation like this:
     /**
-     * 
-     * 
-     * @param login 
+     * Detects bad practices in pull requests for a specific user
+     * 
+     * @param login GitHub username of the user
+     * @returns Observable of array of detected bad practices
      */
     detectBadPracticesByUser(login: string, extraHttpRequestParams?: any): Observable<Array<PullRequestBadPractice>>;

     /**
-     * 
-     * 
-     * @param login 
+     * Retrieves activity data for a specific user
+     * 
+     * @param login GitHub username of the user
+     * @returns Observable of user's activity data
      */
     getActivityByUser(login: string, extraHttpRequestParams?: any): Observable<Activity>;
webapp/src/app/user/pull-request-bad-practice-card/pull-request-bad-practice-card.stories.ts (1)
26-28: Add # prefix to hexadecimal color values.

The label colors are missing the # prefix for hexadecimal values.
-      { id: 1, name: 'bug', color: 'f00000' },
-      { id: 2, name: 'enhancement', color: '008000' }
+      { id: 1, name: 'bug', color: '#f00000' },
+      { id: 2, name: 'enhancement', color: '#008000' }
webapp/src/app/core/modules/openapi/api/activity.service.ts (2)
115-115: Improve code readability with optional chaining.

Use optional chaining to simplify the code and make it more readable.
-        let localVarHttpHeaderAcceptSelected: string | undefined = options && options.httpHeaderAccept;
+        let localVarHttpHeaderAcceptSelected: string | undefined = options?.httpHeaderAccept;

-        let localVarHttpContext: HttpContext | undefined = options && options.context;
+        let localVarHttpContext: HttpContext | undefined = options?.context;

-        let localVarTransferCache: boolean | undefined = options && options.transferCache;
+        let localVarTransferCache: boolean | undefined = options?.transferCache;
Also applies to: 127-127, 132-132

🧰 Tools

🪛 Biome (1.9.4)

[error] 115-115: Change to an optional chain.

Unsafe fix: Change to an optional chain.

(lint/complexity/useOptionalChain)

178-178: Improve code readability with optional chaining.

Use optional chaining to simplify the code and make it more readable.
-        let localVarHttpHeaderAcceptSelected: string | undefined = options && options.httpHeaderAccept;
+        let localVarHttpHeaderAcceptSelected: string | undefined = options?.httpHeaderAccept;

-        let localVarHttpContext: HttpContext | undefined = options && options.context;
+        let localVarHttpContext: HttpContext | undefined = options?.context;

-        let localVarTransferCache: boolean | undefined = options && options.transferCache;
+        let localVarTransferCache: boolean | undefined = options?.transferCache;
Also applies to: 190-190, 195-195

🧰 Tools

🪛 Biome (1.9.4)

[error] 178-178: Change to an optional chain.

Unsafe fix: Change to an optional chain.

(lint/complexity/useOptionalChain)
server/application-server/openapi.yaml (1)

785-794: Enhance PullRequestBadPractice Schema

The PullRequestBadPractice schema defines properties for title, description, and resolved, but it does not specify which fields are mandatory. If these properties are essential, consider adding a required section to enforce validation and ensure data consistency.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b99552c and 0c99d2a.

📒 Files selected for processing (29)

server/application-server/openapi.yaml (5 hunks)
server/application-server/src/main/java/de/tum/in/www1/hephaestus/activity/ActivityController.java (1 hunks)
server/application-server/src/main/java/de/tum/in/www1/hephaestus/activity/ActivityService.java (1 hunks)
server/application-server/src/main/java/de/tum/in/www1/hephaestus/activity/PullRequestBadPracticeRepository.java (1 hunks)
server/application-server/src/main/java/de/tum/in/www1/hephaestus/activity/badpracticedetector/PullRequestBadPracticeDetector.java (1 hunks)
server/application-server/src/main/java/de/tum/in/www1/hephaestus/activity/model/ActivityDTO.java (1 hunks)
server/application-server/src/main/java/de/tum/in/www1/hephaestus/activity/model/PullRequestBadPractice.java (1 hunks)
server/application-server/src/main/java/de/tum/in/www1/hephaestus/activity/model/PullRequestBadPracticeDTO.java (1 hunks)
server/application-server/src/main/java/de/tum/in/www1/hephaestus/activity/model/PullRequestWithBadPracticesDTO.java (1 hunks)
server/application-server/src/main/resources/db/changelog/1738063112622_changelog.xml (1 hunks)
server/application-server/src/main/resources/db/master.xml (1 hunks)
webapp/src/app/app.routes.ts (2 hunks)
webapp/src/app/core/header/header.component.html (1 hunks)
webapp/src/app/core/modules/openapi/.openapi-generator/FILES (2 hunks)
webapp/src/app/core/modules/openapi/api/activity.service.ts (1 hunks)
webapp/src/app/core/modules/openapi/api/activity.serviceInterface.ts (1 hunks)
webapp/src/app/core/modules/openapi/api/api.ts (2 hunks)
webapp/src/app/core/modules/openapi/model/activity.ts (1 hunks)
webapp/src/app/core/modules/openapi/model/models.ts (1 hunks)
webapp/src/app/core/modules/openapi/model/pull-request-bad-practice.ts (1 hunks)
webapp/src/app/core/modules/openapi/model/pull-request-with-bad-practices.ts (1 hunks)
webapp/src/app/home/activity/activity-dashboard.component.html (1 hunks)
webapp/src/app/home/activity/activity-dashboard.component.ts (1 hunks)
webapp/src/app/user/bad-practice-card/bad-practice-card.component.html (1 hunks)
webapp/src/app/user/bad-practice-card/bad-practice-card.component.ts (1 hunks)
webapp/src/app/user/bad-practice-card/bad-practice-card.stories.ts (1 hunks)
webapp/src/app/user/pull-request-bad-practice-card/pull-request-bad-practice-card.component.html (1 hunks)
webapp/src/app/user/pull-request-bad-practice-card/pull-request-bad-practice-card.component.ts (1 hunks)
webapp/src/app/user/pull-request-bad-practice-card/pull-request-bad-practice-card.stories.ts (1 hunks)

🧰 Additional context used

🪛 Biome (1.9.4)

webapp/src/app/app.routes.ts

[error] 51-51: expected , but instead found {

Remove {

(parse)

webapp/src/app/core/modules/openapi/api/activity.service.ts

[error] 115-115: Change to an optional chain.

Unsafe fix: Change to an optional chain.