Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create activity endpoint for bad practice detection #224

Open
wants to merge 19 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove TODO comments(#223)
  • Loading branch information
iam-flo committed Feb 20, 2025
commit d1a1cea426f48d3c2ee0af390c22bef96c279bb7
Original file line number Diff line number Diff line change
Expand Up @@ -24,44 +24,6 @@ public List<PullRequestBadPractice> detectAndSyncBadPractices(PullRequest pullRe
pullRequest.getId()
);

//TODO connect LLM based detection
List<PullRequestBadPractice> newBadPractices = List.of();

return newBadPractices;
}
/*
updateExistingBadPractices(existingBadPractices, newBadPractices);

return saveBadPractices(existingBadPractices, newBadPractices);
}

private List<PullRequestBadPractice> saveBadPractices(
List<PullRequestBadPractice> existingBadPractices,
List<PullRequestBadPractice> detectedBadPractices
) {
List<PullRequestBadPractice> newBadPractices = detectedBadPractices
.stream()
.filter(badPractice -> !existingBadPractices.contains(badPractice))
.toList();

return pullRequestBadPracticeRepository.saveAll(newBadPractices);
return existingBadPractices;
}

private void updateExistingBadPractices(
List<PullRequestBadPractice> existingBadPractices,
List<PullRequestBadPractice> detectedBadPractices
) {
List<PullRequestBadPracticeType> types = detectedBadPractices
.stream()
.map(PullRequestBadPractice::getType)
.toList();

for (PullRequestBadPractice existingBadPractice : existingBadPractices) {
if (!types.contains(existingBadPractice.getType())) {
logger.info("Resolving bad practice: {}", existingBadPractice.getType());
existingBadPractice.setResolved(true);
pullRequestBadPracticeRepository.save(existingBadPractice);
}
}
}*/
}
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
import jakarta.persistence.ManyToMany;
import jakarta.persistence.OneToMany;
import jakarta.persistence.Table;

import java.time.OffsetDateTime;
import java.util.HashSet;
import java.util.Set;
Expand Down