Fixed vstudio build issues #353
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@noahdav I believe it is not safe to tag the object file produced by ml.exe as SAFESEH when actual assembler code in it does not have exception handler setup. In my opinion better approach would be to compile C code with /SAFESEH:no like it is done in release build. As for the path issue, it exists in vc11 and vc12 vcxproj as well so that should be fixed too. Sadly, it looks like this repo is dead so the chance to get the changes accepted is slim. |
|
@levicki ML and ML64 Command-Line Reference says /safeseh is OK to use when the object does not contain any exception handlers, which is the case in contrib/masmx86/inffas32.asm and contrib/masmx86/match686.asm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.