Fix to allow multiple access logs to collect metrics #1100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
bug
dhurley
reviewed
May 30, 2025
internal/collector/nginxossreceiver/internal/scraper/accesslog/nginx_log_scraper.go
Outdated
Show resolved
Hide resolved
internal/collector/nginxossreceiver/internal/scraper/accesslog/nginx_log_scraper.go
Show resolved
Hide resolved
internal/collector/nginxossreceiver/internal/scraper/accesslog/nginx_log_scraper.go
Outdated
Show resolved
Hide resolved
sean-breen
approved these changes
May 30, 2025
dhurley
approved these changes
May 30, 2025
craigell
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Change access log scraper so each access log has its own pipe to fix issue where initializing pipeline would fail for the second access log.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)