-
Notifications
You must be signed in to change notification settings - Fork 92
Fix to allow multiple access logs to collect metrics #1100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
2f423f1
add nil check
aphralG e07ebbb
fix race conditions
aphralG cab1df1
fix race conditions
aphralG 846c064
fix race conditions
aphralG 2c04c8e
fix issue when two formats are set for the same access log
aphralG 660afbd
clean up
aphralG b017233
format
aphralG b982a31
change log
aphralG fa763de
change log
aphralG c83e0b9
Merge branch 'v3' into fix-panic-with-two-log-formats
aphralG 64c90fa
fix multiple access logs
aphralG ed999ba
PR feedback
aphralG 348f7c8
PR feedback
aphralG 263b747
Merge branch 'v3' into fix-panic-with-multiple-logs
aphralG File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.