Skip to content

[ADD] Payroll: Mexico localization #14767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[ADD] Payroll: Mexico localization #14767

wants to merge 1 commit into from
+547 −1

Conversation

larm-odoo
Copy link
Contributor

Adding new localization info.  This document was provided by Miguel Angel Lopez (MIAL).

Original task card for this PR.

@robodoo
Copy link
Collaborator

robodoo commented Oct 2, 2025

Pull request status dashboard

@larm-odoo larm-odoo self-assigned this Oct 2, 2025
@larm-odoo larm-odoo added the 5 label Oct 2, 2025
@C3POdoo C3POdoo requested a review from a team October 2, 2025 21:07
@larm-odoo larm-odoo requested a review from mial-odoo October 2, 2025 21:11
@larm-odoo
Copy link
Contributor Author

Hi @mial-odoo - would you please take a look at this PR, and let me know if there are any changes needed? I followed your document, but I moved some things and rephrased a few things to keep it in line with the template. Any questions, let me know! I am mostly concerned that everything is accurate and correct. Thank you!

mial-odoo
mial-odoo reviewed Oct 3, 2025
View reviewed changes
Copy link
Contributor

@mial-odoo mial-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is looking amazing! Just a few unexpected references, but other than that is pretty good! Thanks

@larm-odoo
Copy link
Contributor Author

Hello @mial-odoo - I have left some comments, since I am unsure how to fix or rephrase some of the sections you commented on. Mostly because I still am unsure of how the entire Mexico payroll functions. Can you help with those 3 incorrectly worded parts mentioned above? Once I know those are correct and accurate, i think this is in good shape for a final tech review! =)

@larm-odoo larm-odoo force-pushed the 19.0-payroll-mexico-localization-larm branch from d08dbee to 7e6b7c8 Compare October 6, 2025 16:31
@larm-odoo larm-odoo requested a review from Felicious October 6, 2025 16:31
@larm-odoo
Copy link
Contributor Author

@Felicious - this is ready for a final tech review

@mial-odoo
Copy link
Contributor

@larm-odoo It's perfect, thanks for everything! :)

@mial-odoo mial-odoo self-requested a review October 6, 2025 18:07
@larm-odoo
Copy link
Contributor Author

Hi @mial-odoo - I see you added items to this PR for the Mexico Fiscal Localization, but this PR is only for the Payroll localization. Could you please remove those additional changes to the fiscal document only, and place those edits on a separate PR, since I created this only for the new doc? Thank you!

@mial-odoo
Copy link
Contributor

Hi @mial-odoo - I see you added items to this PR for the Mexico Fiscal Localization, but this PR is only for the Payroll localization. Could you please remove those additional changes to the fiscal document only, and place those edits on a separate PR, since I created this only for the new doc? Thank you!

Sorry, I asked Felicia if I could do it here, I don't use the console so I can't remove it :(

@Felicious Felicious force-pushed the 19.0-payroll-mexico-localization-larm branch 2 times, most recently from 6b41952 to c035178 Compare October 6, 2025 20:26
@C3POdoo C3POdoo requested a review from a team October 6, 2025 20:27
@Felicious
Copy link
Contributor

I took a look at @mial-odoo's changes, and since he's just adding some links in the fiscal localization doc to this payroll one, I don't think the @odoo/accounting-doc-review would find issue in our changes to their doc. I've tagged them in this thread in case, though, so feel free to comment if you'd like us to remove our edits!

So @larm-odoo, I think we can leave Miguel's links as-is!

Felicious
Felicious approved these changes Oct 7, 2025
View reviewed changes
Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely new doc, @larm-odoo!!

Everything looks wonderful and is written clearly and concisely. I just had some very small optional suggestions that you can look over. After that, this is definitely ready for merge!

@robodoo delegate+

@larm-odoo larm-odoo force-pushed the 19.0-payroll-mexico-localization-larm branch from c035178 to ee6e029 Compare October 8, 2025 16:47
@larm-odoo
Copy link
Contributor Author

@robodoo r+

@robodoo robodoo closed this in 4bb9d34 Oct 8, 2025
@fw-bot fw-bot mentioned this pull request Oct 8, 2025
Open
mial-odoo added a commit that referenced this pull request Oct 8, 2025
@mial-odoo
[IMP] Change image and add payroll references
be84115 
Previous commits ended up with a little less info than intended so this PR adds two things:

Fixes the missing picture in #14582
And adds references to #14767
@mial-odoo mial-odoo mentioned this pull request Oct 8, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Felicious Felicious Felicious approved these changes

@mial-odoo mial-odoo mial-odoo approved these changes

Assignees

@larm-odoo larm-odoo

Labels
5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@larm-odoo @robodoo @mial-odoo @Felicious