improve: PrimaryUpdateAndCacheUtils locks, naming and doc improvements #2799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Attila Mészáros <[email protected]>
…CacheUtils Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
openshift-ci
bot
added
the
do-not-merge/work-in-progress
csviri
changed the title
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
csviri
changed the title
Signed-off-by: Attila Mészáros <[email protected]>
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
@xstefank @metacosm this is the next iteration of the primary caches. It provides an additional and I think preferred way to update the internal caches using update method with retryable optimistic locking. I think this should be the default what users should use. To be honest I'm a bit hesitant if we should provide the other approaches at this point. But would do this in a way that we merge this and in case I remove it in a subsequent PR - so we have history of alternatives. |
metacosm
reviewed
May 15, 2025
|
Replacement for this PR: #2800 |
|
Can we delete the branch? |
|
sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO