improve: status cache for next reconciliation - only the lock version #2800
Conversation
Signed-off-by: Attila Mészáros <[email protected]>
…CacheUtils Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
csviri
changed the title
|
Alternative to: #2799 |
csviri
changed the title
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
| .getControllerEventSource() | ||
| .handleRecentResourceUpdate(ResourceID.fromResource(primary), updatedResource, primary); | ||
| return updatedResource; | ||
| public static <P extends HasMetadata> P editStatusAndCacheResource( |
There was a problem hiding this comment.
I think this method should be renamed patchStatusAndCacheResource to make it clearer that it's using a patch operation. I understand the idea to follow the fabric8 naming but in this case, it's just a bad name :)
There was a problem hiding this comment.
Yeah, problem is that already there is a patchStatusAndCacheResource., but maybe jsonPatchStatusAndCacheResource ?
There was a problem hiding this comment.
ok removed the json prefixes, seemed to long
| logWarnIfResourceVersionPresent(primary); | ||
| return patchAndCacheStatus( | ||
| primary, context, () -> context.getClient().resource(primary).editStatus(operation)); | ||
| public static <P extends HasMetadata> P patchStatusAndCacheResource( |
There was a problem hiding this comment.
This method should be renamed mergePatchStatusAndCacheResource, imo.
There was a problem hiding this comment.
maybe jsonMergePatchStatusAndCacheResource?
There was a problem hiding this comment.
ok removed the json prefixes, seemed to long
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
No description provided.