-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: support for expandable / flex slots #12379
Conversation
src/prebid.js
Outdated
logWarn(`Ad unit banner.format specifies both w/h and wratio/hratio`, adUnit); | ||
return false; | ||
} | ||
return (w ?? h ?? wratio ?? hratio) != null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't we check that w AND h aren't null or wratio AND hratio aren't null ? Instead of having just one non null value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I can tell, I think this looks good. As I mentioned in the last PMC, I don't have a real flex creative to test with - so hopefully another reviewer would be able to check that aspect.
@JulieLorin could you weigh in? Thanks! Is your feedback addressed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JulieLorin could you weigh in? Thanks! Is your feedback addressed
It is ! LGTM
Tread carefully! This PR adds 26 linter errors (possibly disabled through directives):
|
Tread carefully! This PR adds 18 linter errors (possibly disabled through directives):
|
Type of change
Description of change
This adds better support for banner slots with flexible sizes:
format
array instead ofsizes
for an ad unit'smediaTypes.banner
;expdir
can also be supplied there for convenience (alias ofortb2Imp.banner.expdir
);wratio
/hratio
instead of width and height;{wratio: 2, hratio: 1}
becomes[2, 1]
);Other information
#9361