Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: support for expandable / flex slots #12379

Merged
merged 9 commits into from
Mar 7, 2025
Merged

Core: support for expandable / flex slots #12379

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
eae8086
Ad unit validation
dgirardi Oct 29, 2024
5dda1d4
response validation
dgirardi Oct 29, 2024
5222366
allow 100% height in creatives
dgirardi Oct 29, 2024
d1892e4
ortbConverter support for format/wratio/hratio
dgirardi Oct 29, 2024
f213e8b
do not set expdir: undefined
dgirardi Oct 29, 2024
01403f6
Merge branch 'master' into flex
dgirardi Nov 21, 2024
f5e1e7c
Require either w/h or wratio/hratio for banner.format
dgirardi Nov 21, 2024
1f83436
Merge branch 'master' into flex
dgirardi Mar 7, 2025
1332c65
Fix tests for --disable GREEDY
dgirardi Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
do not set expdir: undefined
  • Loading branch information
@dgirardi
dgirardi committed Oct 29, 2024
commit f213e8bc227b182091e0d1c0a65c34371713f9d6
6 changes: 4 additions & 2 deletions src/prebid.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,12 +145,14 @@ function validateBannerMediaType(adUnit) {
}
const sizes = formatSizes ?? bannerSizes ?? [];
const expdir = adUnit.ortb2Imp?.banner?.expdir ?? banner.expdir;
if (expdir != null) {
banner.expdir = expdir;
deepSetValue(validatedAdUnit, 'ortb2Imp.banner.expdir', expdir);
}
if (sizes.length > 0) {
banner.sizes = sizes;
// Deprecation Warning: This property will be deprecated in next release in favor of adUnit.mediaTypes.banner.sizes
validatedAdUnit.sizes = sizes;
banner.expdir = expdir;
deepSetValue(validatedAdUnit, 'ortb2Imp.banner.expdir', expdir);
} else {
logError('Detected a mediaTypes.banner object without a proper sizes field. Please ensure the sizes are listed like: [[300, 250], ...]. Removing invalid mediaTypes.banner object from request.');
delete validatedAdUnit.mediaTypes.banner
Expand Down