Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for named graphs #196

Merged
merged 32 commits into from
Sep 14, 2023
Merged

Adding support for named graphs #196

merged 32 commits into from
Sep 14, 2023

Conversation

QuentinJanuel
Copy link

This pull request will aim to address the issue #3

@bb010g
Copy link

bb010g commented Jul 18, 2023

Is this based on HDTQ (previous implementation: https://github.com/Rummy23/hdtq-java)?

@QuentinJanuel
Copy link
Author

@bb010g Yes

Copy link
Contributor

@ate47 ate47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is fine, I added some comments.

Adding some tests in the core would be better to make this new part reliable.

hdt-api/src/main/java/org/rdfhdt/hdt/triples/TripleID.java Outdated Show resolved Hide resolved

protected AdjacencyList adjY, adjZ, adjIndex;
public AdjacencyList adjY, adjZ, adjIndex;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason for this change?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the class BitmapTriples is used by, for instance, BitmapQuadsIteratorZFOQ which needs to read these fields. This is done with a composition pattern, not inheritance, so protected won't work. The best I could to is creating getters (and setters maybe? didn't check if needed)

@D063520
Copy link
Contributor

D063520 commented Sep 5, 2023

Hi @QuentinJanuel , I saw that you added named graph cat test. This is fine, but what we would need more is the following:

  • index one hdt
  • run all different types of iterators and check if the result is the right one

this is the main test we need. You can ping me if it is not clear ...

@QuentinJanuel
Copy link
Author

Sure no problem, I will prioritize these tests then

@D063520 D063520 marked this pull request as ready for review September 14, 2023 08:51
@D063520 D063520 merged commit 8a73fcd into rdfhdt:dev Sep 14, 2023
@D063520
Copy link
Contributor

D063520 commented Sep 14, 2023

thank you for the contribution and the reviews!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants