Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for named graphs #196

Merged
merged 32 commits into from
Sep 14, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
f69df74
Implemented quad dictionaries for .nq files
QuentinJanuel May 31, 2023
728446d
temp triples can handle quads
QuentinJanuel Jun 1, 2023
3d9e29a
making sure graphs don't affect normal hdt
QuentinJanuel Jun 5, 2023
9a7d09d
FourQuadSectionDictionary needs to implement FourSectionDictionary, n…
QuentinJanuel Jun 15, 2023
7a024f5
quad patterns support (not implemented yet)
QuentinJanuel Jun 15, 2023
82cb465
fixed quadstring
QuentinJanuel Jun 22, 2023
3439c49
save triples (could be optimized)
QuentinJanuel Jun 22, 2023
a4f5bfb
search wip
QuentinJanuel Jun 26, 2023
d672ee9
Fixed search for triples (non quad)
QuentinJanuel Jun 29, 2023
c26b85e
number of graphs is now dynamic
QuentinJanuel Jun 29, 2023
f58cfa6
Adapt code for large files (RoaringBitmap)
QuentinJanuel Jul 11, 2023
bcc095a
roaring bitmap 64
QuentinJanuel Jul 13, 2023
f45facb
accelerated wildcard pattern a bit
QuentinJanuel Jul 13, 2023
1e612c3
BitmapQuadsIterator
QuentinJanuel Jul 17, 2023
8d31b3d
fixed roaring bitmap
QuentinJanuel Jul 20, 2023
c8b0c1e
let quads iterator variables be longs
QuentinJanuel Jul 20, 2023
b1ba3a6
support for ???G, S??G, SP?G & SPOG
QuentinJanuel Jul 20, 2023
0f1685b
?POG & ??OG (ZGFOQ)
QuentinJanuel Jul 28, 2023
5ccc86b
removed forgotten log
QuentinJanuel Jul 28, 2023
257aa30
?PO? & ??O? (ZFOQ)
QuentinJanuel Jul 28, 2023
76ee129
?P?G (YGFOQ)
QuentinJanuel Jul 31, 2023
41abd02
?P?? (YFOQ)
QuentinJanuel Aug 4, 2023
cbfeedc
address https://github.com/rdfhdt/hdt-java/pull/196#discussion_r12416…
QuentinJanuel Aug 28, 2023
b9002a6
address https://github.com/rdfhdt/hdt-java/pull/196#discussion_r12955…
QuentinJanuel Aug 28, 2023
fef55fb
address https://github.com/rdfhdt/hdt-java/pull/196#discussion_r12955…
QuentinJanuel Aug 28, 2023
5233663
address https://github.com/rdfhdt/hdt-java/pull/196#discussion_r12955…
QuentinJanuel Aug 28, 2023
59bba7c
address https://github.com/rdfhdt/hdt-java/pull/196#discussion_r12955…
QuentinJanuel Aug 28, 2023
7ae491c
address https://github.com/rdfhdt/hdt-java/pull/196#discussion_r12958…
QuentinJanuel Aug 28, 2023
eacd5bb
address https://github.com/rdfhdt/hdt-java/pull/196#discussion_r12958…
QuentinJanuel Aug 28, 2023
f61bc58
address https://github.com/rdfhdt/hdt-java/pull/196#discussion_r12959…
QuentinJanuel Aug 31, 2023
c675a01
cat tests for quads
QuentinJanuel Sep 4, 2023
3f4ba41
test quads iterators
QuentinJanuel Sep 5, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
?P?G (YGFOQ)
  • Loading branch information
QuentinJanuel committed Jul 31, 2023
commit 76ee129f189b91da634989a012053b9f8b47b432
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,9 @@ public long selectPrev1(long start) {
@Override
public long selectNext1(long start) {
long pos = rank1(start - 1);
if (pos < bitmap.getLongCardinality()) {
if (pos < bitmap.getLongCardinality())
return select1(pos + 1);
} else
return -1;
return -1;

}
@Override
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,101 @@
package org.rdfhdt.hdt.quads.impl;

import org.rdfhdt.hdt.compact.bitmap.Bitmap;
import org.rdfhdt.hdt.enums.ResultEstimationType;
import org.rdfhdt.hdt.enums.TripleComponentOrder;
import org.rdfhdt.hdt.iterator.SuppliableIteratorTripleID;
import org.rdfhdt.hdt.triples.TripleID;
import org.rdfhdt.hdt.triples.impl.BitmapTriples;
import org.rdfhdt.hdt.triples.impl.BitmapTriplesIteratorYFOQ;

public class BitmapQuadsIteratorYGFOQ implements SuppliableIteratorTripleID {

// resolves ?P?G queries
private final Bitmap bitmapGraph; // the bitmap of the requested graph
private final BitmapTriplesIteratorYFOQ inIt;
private TripleID nextRes = null;
public BitmapQuadsIteratorYGFOQ(BitmapTriples triples, TripleID pattern) {
this.inIt = new BitmapTriplesIteratorYFOQ(
triples,
pattern
);
this.bitmapGraph = triples
.getQuadInfoAG()
.get((int) pattern.getGraph() - 1);
this.goToStart();
this.calculateNext();
}

private boolean isValidZ() {
return this.inIt.posZ != -1
&& this.bitmapGraph.access(this.inIt.posZ - 1);
}

@Override
public void goToStart() {
this.inIt.goToStart();
}

@Override
public boolean hasNext() {
return this.nextRes != null;
}

private void calculateNext() {
this.nextRes = null;
while (this.inIt.hasNext()) {
TripleID next = this.inIt.next().clone();
if (!this.isValidZ())
continue;
this.nextRes = next;
break;
}
}

@Override
public TripleID next() {
TripleID res = this.nextRes.clone();
this.calculateNext();
return res;
}

@Override
public boolean hasPrevious() {
return this.inIt.hasPrevious();
}

@Override
public TripleID previous() {
return this.inIt.previous();
}

@Override
public boolean canGoTo() {
return this.inIt.canGoTo();
}

@Override
public void goTo(long pos) {
this.inIt.goTo(pos);
}

@Override
public long estimatedNumResults() {
return this.inIt.estimatedNumResults();
}

@Override
public ResultEstimationType numResultEstimation() {
return this.inIt.numResultEstimation();
}

@Override
public TripleComponentOrder getOrder() {
return this.inIt.getOrder();
}

@Override
public long getLastTriplePosition() {
return this.inIt.getLastTriplePosition();
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@
import org.rdfhdt.hdt.options.HDTOptions;
import org.rdfhdt.hdt.quads.impl.BitmapQuadsIterator;
import org.rdfhdt.hdt.quads.impl.BitmapQuadsIteratorG;
import org.rdfhdt.hdt.quads.impl.BitmapQuadsIteratorYGFOQ;
import org.rdfhdt.hdt.quads.impl.BitmapQuadsIteratorZFOQ;
import org.rdfhdt.hdt.quads.impl.BitmapQuadsIteratorZGFOQ;
import org.rdfhdt.hdt.triples.IteratorTripleID;
Expand Down Expand Up @@ -298,6 +299,9 @@ public SuppliableIteratorTripleID search(TripleID pattern) {
}
}

if(patternString.equals("?P?G"))
return new BitmapQuadsIteratorYGFOQ(this, pattern);

if(patternString.equals("?PO?") || patternString.equals("??O?"))
return new BitmapQuadsIteratorZFOQ(this, pattern);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ public class BitmapTriples implements TriplesPrivate {

public TripleComponentOrder order;

protected Sequence seqY, seqZ, indexZ, predicateCount;
public Sequence seqY, seqZ, indexZ, predicateCount;
public Bitmap bitmapY, bitmapZ, bitmapIndexZ;

public AdjacencyList adjY, adjZ, adjIndex;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason for this change?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the class BitmapTriples is used by, for instance, BitmapQuadsIteratorZFOQ which needs to read these fields. This is done with a composition pattern, not inheritance, so protected won't work. The best I could to is creating getters (and setters maybe? didn't check if needed)

Expand Down
Loading