Make resolveToValue consider assignments to identifiers (fixes #58) #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://facebook.github.io/jest/blog/2016/09/01/jest-15.html for details what changed. I only did some minimal cleanup to make all tests pass.
In the following example, resolveToValue wouldn't resolve to the value
assigned to "React" because it only looks at the variable
definition, not at assignments to the variable:
```
var React;
React = require('react');
module.exports = React.createClass(...);
```
This diff fixes that. It will make a shallow traversal over the scope
where the variable is defined and look for the last assignment to the
variable.
---
I'm also trying to improve tests by storing component definitions that
are known to have been broken in `src/__tests__/fixtures/`. Adding more
components over time will strengthen the test suit and help catch
regressions.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the following example, resolveToValue wouldn't resolve to the value
assigned to "React" because it only looks at the variable
definition, not at assignments to the variable:
This diff fixes that. It will make a shallow traversal over the scope
where the variable is defined and look for the last assignment to the
variable.
I'm also trying to improve tests by storing component definitions that
are known to have been broken in
src/__tests__/fixtures/. Adding morecomponents over time will strengthen the test suit and help catch
regressions.
Also updates to jest v15.