Make resolveToValue consider assignments to identifiers (fixes #58)

bin/__tests__/react-docgen-test.js

@@ -8,14 +8,15 @@
  *
  */
 
-/*global jasmine, jest, describe, it, expect, afterEach*/
+/*global jasmine, describe, it, expect, afterEach*/
+
+// NOTE: This test spawns a subprocesses that load the files from dist/, not
+// src/. Before running this test run `npm run build` or `npm run watch`.
 
 const TEST_TIMEOUT = 120000;
 
 jasmine.DEFAULT_TIMEOUT_INTERVAL = TEST_TIMEOUT;
 
-jest.disableAutomock();
-
 var fs = require('fs');
 var path = require('path');
 var rimraf = require('rimraf');
@@ -96,8 +97,8 @@ describe('react-docgen CLI', () => {
 
   it('reads from stdin', () => {
     return run([], component).then(([stdout, stderr]) => {
-      expect(stdout.length > 0).toBe(true);
-      expect(stderr.length).toBe(0);
+      expect(stdout).not.toBe('');
+      expect(stderr).toBe('');
     });
   }, TEST_TIMEOUT);
 
@@ -238,7 +239,6 @@ describe('react-docgen CLI', () => {
           '--resolver='+path.join(__dirname, './example/customResolver.js'),
           path.join(__dirname, '../../example/components/Component.js'),
         ]).then(([stdout, stderr]) => {
-          console.log(stderr);
           expect(stdout).toContain('Custom');
         }),
       ]);

package.json

@@ -39,7 +39,7 @@
   "devDependencies": {
     "babel-cli": "^6.9.0",
     "babel-eslint": "^6.0.4",
-    "babel-jest": "^14.1.0",
+    "babel-jest": "^15.0.0",
     "babel-plugin-syntax-flow": "^6.8.0",
     "babel-plugin-transform-flow-strip-types": "^6.8.0",
     "babel-plugin-transform-runtime": "^6.9.0",
@@ -48,7 +48,7 @@
     "cross-spawn": "^4.0.0",
     "eslint": "^3.2.2",
     "flow-bin": "^0.31.0",
-    "jest-cli": "^14.1.0",
+    "jest-cli": "^15.1.1",
     "rimraf": "^2.3.2",
     "temp": "^0.8.1"
   },
@@ -58,15 +58,6 @@
       "bin",
       "src"
     ],
-    "testPathIgnorePatterns": [
-      "/bin/__tests__/example/"
-    ],
-    "unmockedModulePathPatterns": [
-      "node_modules",
-      "tests/utils",
-      "recast",
-      "babel",
-      "babylon"
-    ]
+    "testRegex": "/__tests__/.*-test\\.js$"
   }
 }

src/__tests__/__snapshots__/main-test.js.snap

@@ -0,0 +1,7 @@
+exports[`main fixtures processes component "component_1.js" without errors 1`] = `
+Object {
+  "description": "The is a component to test the document generation",
+  "displayName": "Component",
+  "methods": Array []
+}
+`;

src/__tests__/fixtures/component_1.js

@@ -0,0 +1,12 @@
+var Component, React;
+
+React = require('react');
+
+/**
+ * The is a component to test the document generation
+ */
+Component = React.createClass({
+    displayName: 'Component',
+});
+
+module.exports = Component;

src/__tests__/main-test.js

@@ -8,17 +8,15 @@
  *
  */
 
-/*global jest, describe, beforeEach, it, expect*/
+/*global describe, it, expect*/
 
-jest.disableAutomock();
+import fs from 'fs';
+import path from 'path';
 
-describe('main', () => {
-  var docgen, ERROR_MISSING_DEFINITION;
+import * as docgen from '../main';
+import {ERROR_MISSING_DEFINITION} from '../parse';
 
-  beforeEach(() => {
-    docgen = require('../main');
-    ({ERROR_MISSING_DEFINITION} = require('../parse'));
-  });
+describe('main', () => {
 
   function test(source) {
     it('parses with default resolver/handlers', () => {
@@ -225,4 +223,17 @@ describe('main', () => {
       expect(() => docgen.parse(source)).toThrowError(ERROR_MISSING_DEFINITION);
     });
   });
+
+  describe('fixtures', () => {
+    const fixturePath = path.join(__dirname, 'fixtures');
+    const fileNames = fs.readdirSync(fixturePath);
+    for (let i = 0; i < fileNames.length; i++) {
+      const fileContent = fs.readFileSync(path.join(fixturePath, fileNames[i]));
+
+      it(`processes component "${fileNames[i]}" without errors`, () => {
+        expect(() => docgen.parse(fileContent)).not.toThrowError();
+        expect(docgen.parse(fileContent)).toMatchSnapshot();
+      });
+    }
+  });
 });

src/handlers/__tests__/componentMethodsJsDocHandler-test.js

@@ -8,17 +8,16 @@
  *
  */
 
-/*global jest, describe, beforeEach, it, expect*/
+/*global describe, beforeEach, it, expect*/
 
-jest.disableAutomock();
+import Documentation from '../../Documentation';
+import componentMethodsJsDocHandler from '../componentMethodsJsDocHandler';
 
 describe('componentMethodsHandler', () => {
   let documentation;
-  let componentMethodsJsDocHandler;
 
   beforeEach(() => {
-    documentation = new (require('../../Documentation'));
-    componentMethodsJsDocHandler = require('../componentMethodsJsDocHandler').default;
+    documentation = new Documentation();
   });
 
   it('stays the same when no docblock is present', () => {

src/handlers/__tests__/propTypeHandler-test.js

@@ -10,23 +10,20 @@
 
 /*global jest, describe, it, expect, beforeEach*/
 
-jest.disableAutomock();
 jest.mock('../../Documentation');
+jest.mock('../../utils/getPropType', () => jest.fn(() => ({})));
+
+import {statement, expression} from '../../../tests/utils';
+import Documentation from '../../Documentation';
+import propTypeHandler from '../propTypeHandler';
 
 describe('propTypeHandler', () => {
-  var statement, expression;
   var getPropTypeMock;
   var documentation;
-  var propTypeHandler;
 
   beforeEach(() => {
-    ({statement, expression} = require('../../../tests/utils'));
-    getPropTypeMock = jest.genMockFunction().mockImplementation(() => ({}));
-    jest.setMock('../../utils/getPropType', getPropTypeMock);
-    jest.mock('../../utils/getPropType');
-
-    documentation = new (require('../../Documentation'));
-    propTypeHandler = require('../propTypeHandler').default;
+    getPropTypeMock = require('../../utils/getPropType');
+    documentation = new Documentation();
   });
 
   function template(src) {

src/resolver/__tests__/findAllComponentDefinitions-test.js

@@ -8,28 +8,21 @@
  *
  */
 
-/*global jest, describe, beforeEach, it, expect*/
+/*global describe, it, expect*/
 
-jest.disableAutomock();
+import recast from 'recast';
+import * as utils from '../../../tests/utils';
+import findAllComponentDefinitions from '../findAllComponentDefinitions';
 
 describe('findAllComponentDefinitions', () => {
-  var findAllComponentDefinitions;
-  var recast;
-  var utils;
 
   function parse(source) {
     return findAllComponentDefinitions(
-      utils.parse(source),
+      utils.parse(source, recast),
       recast
     );
   }
 
-  beforeEach(() => {
-    findAllComponentDefinitions = require('../findAllComponentDefinitions').default;
-    utils = require('../../../tests/utils');
-    recast = require('recast');
-  });
-
   describe('React.createClass', () => {
 
     it('finds React.createClass', () => {

src/resolver/__tests__/findAllExportedComponentDefinitions-test.js

@@ -8,15 +8,13 @@
  *
  */
 
-/*global jest, describe, beforeEach, it, expect*/
+/*global describe, it, expect*/
+import recast from 'recast';
+import * as utils from '../../../tests/utils';
 
-jest.disableAutomock();
+import findAllExportedComponentDefinitions from '../findAllExportedComponentDefinitions';
 
 describe('findAllExportedComponentDefinitions', () => {
-  var findAllExportedComponentDefinitions;
-  var utils;
-  var recast;
-
   function parse(source) {
     return utils.parse(source);
   }
@@ -25,13 +23,6 @@ describe('findAllExportedComponentDefinitions', () => {
     return findAllExportedComponentDefinitions(path, recast);
   }
 
-  beforeEach(() => {
-    findAllExportedComponentDefinitions =
-      require('../findAllExportedComponentDefinitions').default;
-    utils = require('../../../tests/utils');
-    recast = require('recast');
-  });
-
   describe('CommonJS module exports', () => {
 
     describe('React.createClass', () => {

src/resolver/__tests__/findExportedComponentDefinition-test.js

@@ -8,29 +8,20 @@
  *
  */
 
-/*global jest, describe, beforeEach, it, expect*/
+/*global describe, it, expect*/
 
-jest.disableAutomock();
+import recast from 'recast';
+import * as utils from '../../../tests/utils';
+import findExportedComponentDefinition from '../findExportedComponentDefinition';
 
 describe('findExportedComponentDefinition', () => {
-  var findExportedComponentDefinition;
-  var utils;
-  var recast;
-
   function parse(source) {
     return findExportedComponentDefinition(
       utils.parse(source),
       recast
     );
   }
 
-  beforeEach(() => {
-    findExportedComponentDefinition =
-      require('../findExportedComponentDefinition').default;
-    utils = require('../../../tests/utils');
-    recast = require('recast');
-  });
-
   describe('CommonJS module exports', () => {
 
     describe('React.createClass', () => {

src/utils/__tests__/docblock-test.js

@@ -8,20 +8,17 @@
  *
  */
 
-/*global jest, describe, beforeEach, it, expect*/
-var os = require('os');
-var EOL = os.EOL;
+/*global describe, it, expect*/
+import os from 'os';
+import {statement} from '../../../tests/utils';
 
-jest.unmock('../docblock');
+import {getDoclets, getDocblock} from '../docblock';
+
+const EOL = os.EOL;
 
 describe('docblock', () => {
 
   describe('getDoclets', () => {
-    let getDoclets;
-
-    beforeEach(() => {
-      ({getDoclets} = require('../docblock'));
-    });
 
     it('extracts single line doclets', () => {
       expect(getDoclets('@foo bar\n@bar baz'))
@@ -37,6 +34,7 @@ describe('docblock', () => {
       expect(getDoclets('@foo bar\nbaz\n@abc\n@bar baz'))
         .toEqual({foo: 'bar\nbaz', abc: true, bar: 'baz'});
     });
+
   });
 
   describe('getDocblock', () => {
@@ -49,14 +47,6 @@ describe('docblock', () => {
       'foo;',
     ];
 
-    let getDocblock;
-    let statement;
-
-    beforeEach(() => {
-      ({getDocblock} = require('../docblock'));
-      ({statement} = require('../../../tests/utils'));
-    });
-
     it('gets the closest docblock of the given node', () => {
       let node = statement(source.join(EOL));
       expect(getDocblock(node)).toEqual(comment.join(EOL));

src/utils/__tests__/getMemberExpressionRoot-test.js

@@ -8,17 +8,17 @@
  *
  */
 
-/*global jest, describe, it, expect*/
+/*global describe, it, expect*/
 
 import {expression} from '../../../tests/utils';
 
-jest.unmock('../getMemberExpressionRoot');
-
-var getMemberExpressionRoot = require('../getMemberExpressionRoot').default;
+import getMemberExpressionRoot from '../getMemberExpressionRoot';
 
 describe('getMemberExpressionRoot', () => {
+
   it('returns the root of a member expression', () => {
     var root = getMemberExpressionRoot(expression('foo.bar.baz'));
     expect(root.node).toEqualASTNode(expression('foo').node);
   });
+
 });