Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test creating two content filter topics with the same topic name #2546

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

Mario-DL
Copy link
Contributor

This PR adds the proper test in rclcpp that checks for a successful creation of two content filter topics for the same topic name.

Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with green CI.

@ahcorde
Copy link
Contributor

ahcorde commented Jun 3, 2024

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@ahcorde
Copy link
Contributor

ahcorde commented Jun 3, 2024

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit 9266086 into ros2:master Jun 3, 2024
2 checks passed
fujitatomoya pushed a commit that referenced this pull request Jun 4, 2024
mergify bot pushed a commit that referenced this pull request Jun 5, 2024
…2546) (#2549)

Signed-off-by: Mario-DL <[email protected]>
Co-authored-by: Mario Domínguez López <[email protected]>
(cherry picked from commit 7c09688)
mergify bot pushed a commit that referenced this pull request Jun 5, 2024
…2546) (#2549)

Signed-off-by: Mario-DL <[email protected]>
Co-authored-by: Mario Domínguez López <[email protected]>
(cherry picked from commit 7c09688)
mergify bot pushed a commit that referenced this pull request Jun 5, 2024
…2546) (#2549)

Signed-off-by: Mario-DL <[email protected]>
Co-authored-by: Mario Domínguez López <[email protected]>
(cherry picked from commit 7c09688)
ahcorde added a commit that referenced this pull request Jun 6, 2024
…2546) (#2549) (#2552)

Signed-off-by: Mario-DL <[email protected]>
Co-authored-by: Mario Domínguez López <[email protected]>
(cherry picked from commit 7c09688)

Co-authored-by: Alejandro Hernández Cordero <[email protected]>
fujitatomoya pushed a commit that referenced this pull request Jun 7, 2024
…2546) (#2549) (#2550)

Signed-off-by: Mario-DL <[email protected]>
Co-authored-by: Mario Domínguez López <[email protected]>
(cherry picked from commit 7c09688)

Co-authored-by: Alejandro Hernández Cordero <[email protected]>
fujitatomoya pushed a commit that referenced this pull request Jun 12, 2024
…2546) (#2549) (#2551)

Signed-off-by: Mario-DL <[email protected]>
Co-authored-by: Mario Domínguez López <[email protected]>
(cherry picked from commit 7c09688)

Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants