Add a way to use reference-types in InternedStruct::new #589
+295
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for salsa-rs canceled.
|
nikomatsakis
requested changes
Oct 4, 2024
nikomatsakis
requested changes
Oct 4, 2024
puuuuh
force-pushed
the
master
branch
2 times, most recently
from
bdf5d33
to
d48384a
Compare
CodSpeed Performance ReportMerging #589 will not alter performanceComparing Summary
|
|
Hi @puuuuh -- can you rebase + fix the clippy warnings? The miri failure should go away then. |
|
I'll take a look a bit later at your other comments, are there any outstanding questions? I'd like to merge this. |
Co-authored-by: Niko Matsakis <[email protected]>
Co-authored-by: Niko Matsakis <[email protected]>
Co-authored-by: Niko Matsakis <[email protected]>
Co-authored-by: Niko Matsakis <[email protected]>
nikomatsakis
approved these changes
Oct 14, 2024
|
This looks great! Let's merge it, we can probably refine the unsafe code a bit but overall looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #583