pgmq don't manipulate sequences during upgrade #1471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The script being deleted was a hacky solution we put in place to resolve a pg_dump segfault due to its interaction with pgmq tables. It currently introduces errors where sequences become owned by supabase_admin and are inaccessible to users after upgrading. https://supabase.slack.com/archives/C05Q0CVC65B/p1741093731995359 This update mirrors the same code's removal from our on-backup hook here: https://github.com/supabase/infrastructure/pull/21405/files
olirice
changed the title
pcnc
approved these changes
Mar 7, 2025
|
To be validated in staging prior to merging - https://supabase.slack.com/archives/C05Q0CVC65B/p1741359614936839?thread_ts=1741093731.995359&cid=C05Q0CVC65B |
|
@pcnc would be good to get this one reviewed as pg17 will likely trigger a lot of upgrades |
|
Maybe needs rebase and testing? |
|
Shouldn't need to do that, we just need to trigger the publish pg_upgrade scripts job |
|
Tested on local infra, fixed sequence ownership issues for both 15 -> 17 and 17 -> 17 |
soedirgo
approved these changes
Jul 7, 2025
samrose
added a commit
that referenced
this pull request
Jul 7, 2025
samrose
added a commit
that referenced
this pull request
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script being deleted was a hacky solution we put in place to resolve a pg_dump segfault due to its interaction with pgmq tables. It currently introduces errors where sequences become owned by supabase_admin and are inaccessible to users after upgrading. https://supabase.slack.com/archives/C05Q0CVC65B/p1741093731995359
This update mirrors the same code's removal from our on-backup hook here: https://github.com/supabase/infrastructure/pull/21405/files