Skip to content

[lldb] Script determinism of TestSwiftActorUnprioritisedJobs #10435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kastiglione
Copy link

No description provided.

@kastiglione kastiglione requested a review from a team as a code owner April 4, 2025 22:30
@kastiglione
Copy link
Author

another attempt at #10417

@kastiglione
Copy link
Author

@swift-ci test macOS

@artemcm
Copy link

artemcm commented Apr 8, 2025

@swift-ci test Linux platform

@artemcm
Copy link

artemcm commented Apr 8, 2025

@swift-ci test Windows platform

@kastiglione kastiglione force-pushed the dl/lldb-Script-determinism-of-TestSwiftActorUnprioritisedJobs branch from 12f1313 to 0335696 Compare April 15, 2025 21:07
@kastiglione
Copy link
Author

@swift-ci test

@kastiglione
Copy link
Author

Resuming work on this PR

@kastiglione
Copy link
Author

@swift-ci test linux

2 similar comments
@kastiglione
Copy link
Author

@swift-ci test linux

@kastiglione
Copy link
Author

@swift-ci test linux

@kastiglione
Copy link
Author

@swift-ci test

@kastiglione
Copy link
Author

@swift-ci test linux

@kastiglione
Copy link
Author

@swift-ci test macOS

@kastiglione
Copy link
Author

@swift-ci test

@kastiglione
Copy link
Author

@swift-ci test linux

@kastiglione
Copy link
Author

@swift-ci test macOS

@kastiglione
Copy link
Author

So far, tests are passing consistently.

@kastiglione
Copy link
Author

@swift-ci test linux

@kastiglione
Copy link
Author

@swift-ci test

@kastiglione
Copy link
Author

@swift-ci test macOS

@kastiglione
Copy link
Author

@swift-ci test linux

2 similar comments
@kastiglione
Copy link
Author

@swift-ci test linux

@kastiglione
Copy link
Author

@swift-ci test linux

@kastiglione
Copy link
Author

@swift-ci test macOS

@kastiglione
Copy link
Author

kastiglione commented Apr 17, 2025

New set of logs after increasing sleep wait time from 2s to 5s.

Expand logs

macOS CI Logs:

Linux CI Logs:

@kastiglione
Copy link
Author

@swift-ci test linux

@kastiglione kastiglione force-pushed the dl/lldb-Script-determinism-of-TestSwiftActorUnprioritisedJobs branch from e7d3bf0 to 7631872 Compare June 24, 2025 21:01
@kastiglione
Copy link
Author

@swift-ci test

@kastiglione
Copy link
Author

@swift-ci test

@kastiglione
Copy link
Author

@swift-ci test

@kastiglione
Copy link
Author

@swift-ci test macOS

1 similar comment
@kastiglione
Copy link
Author

@swift-ci test macOS

@kastiglione
Copy link
Author

@swift-ci test

@kastiglione
Copy link
Author

@swift-ci test macOS

5 similar comments
@kastiglione
Copy link
Author

@swift-ci test macOS

@kastiglione
Copy link
Author

@swift-ci test macOS

@kastiglione
Copy link
Author

@swift-ci test macOS

@kastiglione
Copy link
Author

@swift-ci test macOS

@kastiglione
Copy link
Author

@swift-ci test macOS

@kastiglione
Copy link
Author

@swift-ci test

@adrian-prantl adrian-prantl merged commit 14ea9a3 into swift/release/6.2 Jun 27, 2025
3 checks passed
@adrian-prantl adrian-prantl deleted the dl/lldb-Script-determinism-of-TestSwiftActorUnprioritisedJobs branch June 27, 2025 22:28
kastiglione added a commit that referenced this pull request Jun 30, 2025
* [lldb] Make TestSwiftActorUnprioritisedJobs deterministic

* Run and show `bt all`

* Attempt forward progress of other threads

* Add missing thread.Suspend()

* Unconditionally run other threads

* Increase sleep wait

* Add actor call to hopefully initialize swift concurrency threads

* New algorithm to ensure actor is sufficiently setup

Credit Adrian for the idea.

* Add IsValid asserts

* New approach did not work, restore previous

* Another round of changes

* Remove dead test code; Run the test 20x

* Pause to allow for occupy() call

* Remove stress testing of multiple test runs

(cherry picked from commit 14ea9a3)

(cherry-picked from commit 9a32a3a538ec30e8252c4d6be71d17d1b289ce29)
kastiglione added a commit that referenced this pull request Jun 30, 2025
* [lldb] Make TestSwiftActorUnprioritisedJobs deterministic

* Run and show `bt all`

* Attempt forward progress of other threads

* Add missing thread.Suspend()

* Unconditionally run other threads

* Increase sleep wait

* Add actor call to hopefully initialize swift concurrency threads

* New algorithm to ensure actor is sufficiently setup

Credit Adrian for the idea.

* Add IsValid asserts

* New approach did not work, restore previous

* Another round of changes

* Remove dead test code; Run the test 20x

* Pause to allow for occupy() call

* Remove stress testing of multiple test runs

(cherry picked from commit 14ea9a3)

(cherry-picked from commit 9a32a3a538ec30e8252c4d6be71d17d1b289ce29)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants