Skip to content

[lldb] Script determinism of TestSwiftActorUnprioritisedJobs #10435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -7,24 +7,21 @@
class TestCase(TestBase):

@swiftTest
@skipUnlessFoundation
@skipIfWindows # temporarily skip test until fails can be investigated
@skipIfLinux # temporarily skip test until fails can be investigated
@skipIfDarwin # temporarily skip test until fails can be investigated
def test_actor_unprioritised_jobs(self):
"""Verify that an actor exposes its unprioritised jobs (queue)."""
self.build()
_, _, thread, _ = lldbutil.run_to_source_breakpoint(
self, "break here", lldb.SBFileSpec("main.swift")
)
frame = thread.GetSelectedFrame()
_, _, thread, _ = lldbutil.run_to_name_breakpoint(self, "breakHere")

frame = thread.frames[0]
self.assertEqual(frame.var("a.data").unsigned, 15)

defaultActor = frame.var("a.$defaultActor")
self.assertEqual(defaultActor.summary, "running")

unprioritised_jobs = defaultActor.GetChildMemberWithName("unprioritised_jobs")
# There are 4 child tasks (async let), the first one occupies the actor
# with a sleep, the next 3 go on to the queue.
# TODO: rdar://148377173
# self.assertEqual(unprioritised_jobs.num_children, 3)
# with a call to readLine, the next 3 go on the queue.
self.assertEqual(unprioritised_jobs.num_children, 3)
for job in unprioritised_jobs:
self.assertRegex(job.name, r"^\d+")
self.assertRegex(job.summary, r"^id:\d+ flags:\S+")
self.assertRegex(job.summary, r"^id:[1-9]\d* flags:\S+")
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
import Foundation

actor Actor {
var data: Int = 15

func occupy() async {
Thread.sleep(forTimeInterval: 100)
_ = readLine()
}

func work() async -> Int {
Expand All @@ -14,13 +12,25 @@ actor Actor {
}
}

func breakHere(_ a: Actor) {}

@main struct Entry {
static func main() async {
let a = Actor()
async let _ = a.occupy()
async let _ = a.work()
async let _ = a.work()
async let _ = a.work()
print("break here")

async let w: Void = a.occupy()
// Provide time for the global concurrent executor to run this async
// let, which enqueues a "blocking" job on the actor.
try? await Task.sleep(for: .seconds(2))

async let x = a.work()
async let y = a.work()
async let z = a.work()
// Provide time for the global concurrent executor to kick off of these
// async let tasks, which in turn enqueue jobs on the busy actor.
try? await Task.sleep(for: .seconds(2))

breakHere(a)
await print(w, x, y, z)
}
}