Skip to content

[Concurrency] Add underscore prefixes for not yet official API. #81472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025

Conversation

al45tair
Copy link
Contributor

Custom main and global executors work hasn't passed Swift Evolution yet, so we need to avoid leaking it as API until it does.

To that end, underscore all the things.

rdar://151147606

@al45tair al45tair requested review from a team, ktoso, jckarter, hborla and slavapestov as code owners May 13, 2025 10:32
@al45tair al45tair force-pushed the eng/PR-151147606 branch from a43668e to 2d31214 Compare May 13, 2025 10:32
@al45tair al45tair changed the title [Concurrency] Add unscore prefixes for not yet official API. [Concurrency] Add underscore prefixes for not yet official API. May 13, 2025
@al45tair
Copy link
Contributor Author

@swift-ci Please smoke test

Copy link
Contributor

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thank you! Too bad the other alternatives to hide these didn't quite work out, looks good 👍

Custom main and global executors work hasn't passed Swift Evolution yet,
so we need to avoid leaking it as API until it does.

To that end, underscore all the things.

rdar://151147606
@al45tair al45tair force-pushed the eng/PR-151147606 branch from 2d31214 to c0ccdff Compare May 14, 2025 10:57
@al45tair
Copy link
Contributor Author

al45tair commented May 14, 2025

Looks like I missed an underscore in one of the Linux files (the macOS failure was spurious). Let's try that again.

@al45tair
Copy link
Contributor Author

@swift-ci Please smoke test

@al45tair al45tair merged commit 7f97e8d into swiftlang:main May 15, 2025
3 checks passed
hamishknight added a commit to hamishknight/swift that referenced this pull request May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants