[cxx-interop] Relax a SILVerifier assertion for immortal reference types #81614
+27
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egorzhdan
requested review from
zoecarver,
Xazax-hun,
j-hui,
fahadnayyar,
susmonteiro,
hnrklssn and
jckarter
as code owners
|
@swift-ci please test |
nate-chandler
approved these changes
May 19, 2025
egorzhdan
force-pushed
the
egorzhdan/silverifier-trivial-frt
branch
from
a78d8ba to
2b3263f
Compare
|
@swift-ci please test |
egorzhdan
changed the title
j-hui
approved these changes
May 19, 2025
lib/SIL/Verifier/SILVerifier.cpp
Outdated
| @@ -1059,7 +1059,13 @@ class SILVerifier : public SILVerifierBase<SILVerifier> { | |||
|
|
|||
| auto objectTy = value->getType().unwrapOptionalType(); | |||
|
|
|||
| require(objectTy.isReferenceCounted(F.getModule()), | |||
| // C++ foreign reference types are represented as trivially lowered types | |||
There was a problem hiding this comment.
Nit:
Suggested change
| // C++ foreign reference types are represented as trivially lowered types | |
| // Immortal C++ foreign reference types are represented as trivially lowered types |
(because this isn't true for SWIFT_SHARED_REFERENCE types, right?)
There was a problem hiding this comment.
Good catch! Fixed.
| require(objectTy.isReferenceCounted(F.getModule()), | ||
| // C++ foreign reference types are represented as trivially lowered types | ||
| // since they do not require retain/release calls. | ||
| bool isImmortalFRT = objectTy.isForeignReferenceType() && |
There was a problem hiding this comment.
Is this also true for SWIFT_UNSAFE_REFERENCEs?
There was a problem hiding this comment.
Yeap! From the compiler point of view, they're the same thing, except if strictly safe mode is enabled – both SWIFT_UNSAFE_REFERENCE and SWIFT_IMMORTAL_REFERENCE macros expand into retain:immortal and release:immortal.
Immortal C++ foreign reference types get TrivialTypeLowering instead of ReferenceTypeLowering, since they do not have retain/release lifetime operations. This was tripping up an assertion in SILVerifier. rdar://147251759 / resolves #80065
egorzhdan
force-pushed
the
egorzhdan/silverifier-trivial-frt
branch
from
2b3263f to
2e3df1c
Compare
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Immortal C++ foreign reference types get TrivialTypeLowering instead of ReferenceTypeLowering, since they do not have retain/release lifetime operations. This was tripping up an assertion in SILVerifier.
rdar://147251759 / resolves #80065