-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
frozen right column header and data misalign #810
base: master
Are you sure you want to change the base?
Conversation
@@ -116,7 +116,8 @@ export class DataTableBodyRowComponent { | |||
const bodyWidth = parseInt(this.innerWidth + '', 0); | |||
const totalDiff = widths.total - bodyWidth; | |||
const offsetDiff = totalDiff - offsetX; | |||
const offset = (offsetDiff + this.scrollbarHelper.width) * -1; | |||
// const offset = (offsetDiff + this.scrollbarHelper.width) * -1; | |||
const offset = (offsetDiff) * -1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will cause incorrect scrollbars on windows.
For both frozenLeft and Right when I set columnMode to force the header columns get misaligned when I resize the window. Will this PR fix that? |
@keyeMyria - can you make a new PR w/o the release files? I can't tell exactly what you changed. |
@keyeMyria - would you mind making a new PR w/ latest and no release files? |
@@ -79,7 +80,7 @@ export class DataTableBodyRowComponent { | |||
|
|||
@HostBinding('style.width.px') | |||
get columnsTotalWidths(): string { | |||
return this.columnGroupWidths.total; | |||
return (this.columnGroupWidths.total - 15) + ''; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@keyeMyria where did 15 come from? If you need a constant value, it's easier to read with a const veryDescriptiveName = 15;
first
What's the status with this fix ? |
Waiting for a rebase without release files. |
@keyeMyria , have you got time to do the rebase without release files so to finalize your PR ? |
can anyone work to complete this? frozenRight with scrollbar doesn't work. |
What is the state here? Is there any progress (or do you propose any temporary fix) ? frozenLeft works perfectly, but frozenRight is still misaligned (version 14.0.0). I did a temporary fix by adding this as general style: .ngx-datatable.material .datatable-body .datatable-body-row .datatable-row-right.datatable-row-group{ margin-left: 15px; } |
This is still an issue workaround by @seawave23 works fine for me thanks! |
Thanks @seawave23 , this workaround works fine to me. |
frozen right column header and data misalign