Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frozen right column header and data misalign #810

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

wahello
Copy link

@wahello wahello commented Jun 12, 2017

frozen right column header and data misalign

@@ -116,7 +116,8 @@ export class DataTableBodyRowComponent {
const bodyWidth = parseInt(this.innerWidth + '', 0);
const totalDiff = widths.total - bodyWidth;
const offsetDiff = totalDiff - offsetX;
const offset = (offsetDiff + this.scrollbarHelper.width) * -1;
// const offset = (offsetDiff + this.scrollbarHelper.width) * -1;
const offset = (offsetDiff) * -1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will cause incorrect scrollbars on windows.

@tscislo
Copy link

tscislo commented Aug 14, 2017

For both frozenLeft and Right when I set columnMode to force the header columns get misaligned when I resize the window. Will this PR fix that?

@amcdnl
Copy link
Contributor

amcdnl commented Aug 14, 2017

@keyeMyria - can you make a new PR w/o the release files? I can't tell exactly what you changed.

@amcdnl
Copy link
Contributor

amcdnl commented Aug 22, 2017

@keyeMyria - would you mind making a new PR w/ latest and no release files?

@@ -79,7 +80,7 @@ export class DataTableBodyRowComponent {

@HostBinding('style.width.px')
get columnsTotalWidths(): string {
return this.columnGroupWidths.total;
return (this.columnGroupWidths.total - 15) + '';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@keyeMyria where did 15 come from? If you need a constant value, it's easier to read with a const veryDescriptiveName = 15; first

@darkurse
Copy link

What's the status with this fix ?

@amcdnl
Copy link
Contributor

amcdnl commented Oct 31, 2017

Waiting for a rebase without release files.

@darkurse
Copy link

darkurse commented Nov 6, 2017

@keyeMyria , have you got time to do the rebase without release files so to finalize your PR ?

@evm2556
Copy link

evm2556 commented Jul 26, 2018

can anyone work to complete this? frozenRight with scrollbar doesn't work.

@seawave23
Copy link

seawave23 commented Nov 19, 2018

What is the state here? Is there any progress (or do you propose any temporary fix) ? frozenLeft works perfectly, but frozenRight is still misaligned (version 14.0.0). I did a temporary fix by adding this as general style: .ngx-datatable.material .datatable-body .datatable-body-row .datatable-row-right.datatable-row-group{ margin-left: 15px; }

@FreshDoktor
Copy link

FreshDoktor commented Mar 31, 2021

This is still an issue workaround by @seawave23 works fine for me thanks!

@liuyiffan
Copy link

Thanks @seawave23 , this workaround works fine to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants