[AIBundle] Add missing configuration for stores #260
Merged
+275
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guikingone
requested review from
chr-hertel,
Nyholm and
OskarStark
as code owners
OskarStark
approved these changes
Aug 5, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR adds missing configuration for additional vector stores in the AI Bundle. The PR implements configuration support for 5 new store types (Meilisearch, Memory, Neo4j, Qdrant, and SurrealDB) that were recently added but lacked proper bundle integration.
Key changes:
- Added configuration options for 5 new vector store types
- Updated service container definitions to properly instantiate these stores
- Updated documentation to reflect all supported store types
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/ai-bundle/config/options.php | Defines configuration schema for new store types with their required and optional parameters |
| src/ai-bundle/src/AiBundle.php | Implements service container configuration logic for instantiating the new store types |
| src/ai-bundle/tests/DependencyInjection/AiBundleTest.php | Adds test configuration examples for all new store types |
| src/ai-bundle/doc/index.rst | Updates documentation comment to list all supported store types |
Guikingone
force-pushed
the
ai-bundle/meilisearch
branch
from
d92a38a to
0e976d0
Compare
OskarStark
approved these changes
Aug 5, 2025
Guikingone
force-pushed
the
ai-bundle/meilisearch
branch
2 times, most recently
from
cc5f5af to
7882b17
Compare
Guikingone
force-pushed
the
ai-bundle/meilisearch
branch
from
7882b17 to
ffca876
Compare
OskarStark
approved these changes
Aug 6, 2025
|
Thank you @Guikingone. |
OskarStark
added a commit
that referenced
this pull request
Aug 6, 2025
…ngone) This PR was merged into the main branch. Discussion ---------- [AIBundle] fix missing endpoint for Meilisearch store | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | Docs? | no | Issues | #260 | License | MIT Hi 👋🏻 A small fix for the meilisearch store, the endpoint was not sent, tests fixed. Commits ------- c3edd4e fix(ai-bundle): missing endpoint for meilisearch store
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋🏻
Following the recently merged PR for vector stores, here's the missing configuration for each of them.