-
Notifications
You must be signed in to change notification settings - Fork 559
[PRO-213] Dashboard: Empty chart state copy changes #7477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PRO-213] Dashboard: Empty chart state copy changes #7477
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7477 +/- ##
=======================================
Coverage 51.92% 51.92%
=======================================
Files 949 949
Lines 64148 64148
Branches 4229 4229
=======================================
Hits 33311 33311
Misses 30731 30731
Partials 106 106
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
size-limit report 📦
|
809e3df
to
a2bfab5
Compare
6b07de0
to
0d86ce8
Compare
Merge activity
|
<!-- ## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes" If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000): ## Notes for the reviewer Anything important to call out? Be sure to also clarify these in your comments. ## How to test Unit tests, playground, etc. --> <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on updating the `EmptyStateCard` component across various files, including changes to its props, styling, and the metrics displayed. It simplifies the component's usage and modifies the metrics for clarity and relevance. ### Detailed summary - Updated `EmptyStateCard` to remove unnecessary props in `RpcMethodBarChartCardUI.tsx`. - Modified metric and link props in `EngineCloudBarChartCardUI.tsx`. - Changed `EmptyStateCard` metrics in `EmptyStateCard.stories.tsx` and other files to be more relevant. - Made `metric` prop optional in `EmptyStateCard.tsx`. - Enhanced styling for `EmptyStateContent` in `EmptyStateCard.tsx`. - Adjusted rendering logic for `EmptyStateContent` to improve clarity and user experience. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
a2bfab5
to
2bfc9b2
Compare
0d86ce8
to
2fd5b84
Compare
PR-Codex overview
This PR focuses on updating the
EmptyStateCard
component across various files, modifying its props and appearance, and changing the metrics displayed in different contexts.Detailed summary
link
andmetric
props from someEmptyStateCard
instances.metric
values in multipleEmptyStateCard
usages.EmptyStateCard
component to makemetric
optional.EmptyStateCard
andEmptyStateContent
components.