Skip to content

[PRO-213] Dashboard: Empty chart state copy changes #7477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented Jun 30, 2025


PR-Codex overview

This PR focuses on updating the EmptyStateCard component across various files, modifying its props and appearance, and changing the metrics displayed in different contexts.

Detailed summary

  • Removed link and metric props from some EmptyStateCard instances.
  • Changed metric values in multiple EmptyStateCard usages.
  • Updated EmptyStateCard component to make metric optional.
  • Enhanced styling for the EmptyStateCard and EmptyStateContent components.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Jun 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 30, 2025 4:24pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Jun 30, 2025 4:24pm
nebula ⬜️ Skipped (Inspect) Jun 30, 2025 4:24pm
thirdweb_playground ⬜️ Skipped (Inspect) Jun 30, 2025 4:24pm
wallet-ui ⬜️ Skipped (Inspect) Jun 30, 2025 4:24pm

Copy link

linear bot commented Jun 30, 2025

@vercel vercel bot temporarily deployed to Preview – wallet-ui June 30, 2025 13:24 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula June 30, 2025 13:24 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 June 30, 2025 13:24 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground June 30, 2025 13:24 Inactive
Copy link

changeset-bot bot commented Jun 30, 2025

⚠️ No Changeset found

Latest commit: 2fd5b84

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Jun 30, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Jun 30, 2025
@MananTank MananTank marked this pull request as ready for review June 30, 2025 13:24
@MananTank MananTank requested review from a team as code owners June 30, 2025 13:24
Copy link
Member Author

MananTank commented Jun 30, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Jun 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.92%. Comparing base (2bfc9b2) to head (2fd5b84).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7477   +/-   ##
=======================================
  Coverage   51.92%   51.92%           
=======================================
  Files         949      949           
  Lines       64148    64148           
  Branches     4229     4229           
=======================================
  Hits        33311    33311           
  Misses      30731    30731           
  Partials      106      106           
Flag Coverage Δ *Carryforward flag
packages 51.92% <ø> (ø) Carriedforward from 2bfc9b2

*This pull request uses carry forward flags. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Jun 30, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 63.11 KB (0%) 1.3 s (0%) 352 ms (+54.21% 🔺) 1.7 s
thirdweb (cjs) 352.76 KB (0%) 7.1 s (0%) 1.7 s (+8.35% 🔺) 8.7 s
thirdweb (minimal + tree-shaking) 5.72 KB (0%) 115 ms (0%) 115 ms (+855.3% 🔺) 229 ms
thirdweb/chains (tree-shaking) 530 B (0%) 11 ms (0%) 33 ms (+740.52% 🔺) 43 ms
thirdweb/react (minimal + tree-shaking) 19.59 KB (0%) 392 ms (0%) 52 ms (+72.43% 🔺) 444 ms

@graphite-app graphite-app bot force-pushed the 06-30-_pro-211_pro-210_dashboard_copy_changes branch 2 times, most recently from 809e3df to a2bfab5 Compare June 30, 2025 15:57
@graphite-app graphite-app bot force-pushed the 06-30-_pro-213_dashboard_empty_chart_state_copy_changes branch from 6b07de0 to 0d86ce8 Compare June 30, 2025 15:57
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground June 30, 2025 15:57 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 June 30, 2025 15:57 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula June 30, 2025 15:57 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui June 30, 2025 15:57 Inactive
Copy link
Contributor

graphite-app bot commented Jun 30, 2025

Merge activity

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on updating the `EmptyStateCard` component across various files, including changes to its props, styling, and the metrics displayed. It simplifies the component's usage and modifies the metrics for clarity and relevance.

### Detailed summary
- Updated `EmptyStateCard` to remove unnecessary props in `RpcMethodBarChartCardUI.tsx`.
- Modified metric and link props in `EngineCloudBarChartCardUI.tsx`.
- Changed `EmptyStateCard` metrics in `EmptyStateCard.stories.tsx` and other files to be more relevant.
- Made `metric` prop optional in `EmptyStateCard.tsx`.
- Enhanced styling for `EmptyStateContent` in `EmptyStateCard.tsx`.
- Adjusted rendering logic for `EmptyStateContent` to improve clarity and user experience.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@graphite-app graphite-app bot force-pushed the 06-30-_pro-211_pro-210_dashboard_copy_changes branch from a2bfab5 to 2bfc9b2 Compare June 30, 2025 16:15
@graphite-app graphite-app bot force-pushed the 06-30-_pro-213_dashboard_empty_chart_state_copy_changes branch from 0d86ce8 to 2fd5b84 Compare June 30, 2025 16:15
@vercel vercel bot temporarily deployed to Preview – docs-v2 June 30, 2025 16:15 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground June 30, 2025 16:15 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula June 30, 2025 16:15 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui June 30, 2025 16:15 Inactive
Base automatically changed from 06-30-_pro-211_pro-210_dashboard_copy_changes to main June 30, 2025 16:24
@graphite-app graphite-app bot merged commit 2fd5b84 into main Jun 30, 2025
22 checks passed
@graphite-app graphite-app bot deleted the 06-30-_pro-213_dashboard_empty_chart_state_copy_changes branch June 30, 2025 16:26
@vercel vercel bot temporarily deployed to Production – thirdweb_playground June 30, 2025 16:26 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui June 30, 2025 16:26 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 June 30, 2025 16:26 Inactive
@vercel vercel bot temporarily deployed to Production – nebula June 30, 2025 16:26 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb-www June 30, 2025 16:41 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants